Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add label pods controller to infra and add int tests #3072

Merged
merged 2 commits into from
May 16, 2024

Conversation

jaskaransarkaria
Copy link
Contributor

@jaskaransarkaria jaskaransarkaria commented May 15, 2024

  • move label pods controller to be deployed at infra
  • add depends_on to as many components as possible so that the controller can label as many components as possible (the controller will pick up other pods on recreate or update)
  • add int tests
  • tested by bringing up a fresh cluster

@jaskaransarkaria jaskaransarkaria requested a review from a team as a code owner May 15, 2024 15:43
@poornima-krishnasamy
Copy link
Contributor

@jaskaransarkaria should we add the label_pods in core layer so it is ready before other components are installed?

@jaskaransarkaria jaskaransarkaria merged commit 8645a84 into main May 16, 2024
9 checks passed
@jaskaransarkaria jaskaransarkaria deleted the add-label-pods-controller branch May 16, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants