Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old cccd-production SQS IAM ARNs #29302

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

mpw5
Copy link
Contributor

@mpw5 mpw5 commented Jan 31, 2025

No description provided.

@mpw5 mpw5 requested a review from a team as a code owner January 31, 2025 17:04
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@mpw5 mpw5 force-pushed the remove-cclf-production-sqs-iam branch from b9bd254 to c937cd8 Compare February 3, 2025 15:45
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 0 to be created, 1 to be destroyed, 2 to be updated, 0 to be replaced and 66 unchanged.

Resources to destroy:

- aws_sqs_queue_policy.responses_for_cccd

Resources to update:

! aws_sqs_queue_policy.claims_for_cclf_policy
! module.cccd_rds.aws_db_parameter_group.custom_parameters

@sablumiah
Copy link
Contributor

This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team.
Reason:
🕵️‍♂️ Manual review required: OPA policy checks did not pass.
Please raise it in #ask-cloud-platform Slack channel.

@mpw5 mpw5 merged commit 8879abf into main Feb 3, 2025
14 checks passed
@mpw5 mpw5 deleted the remove-cclf-production-sqs-iam branch February 3, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants