Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding entra-id-scim function #978

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Conversation

julialawrence
Copy link
Contributor

@julialawrence julialawrence commented Sep 9, 2024

Related ticket:
ministryofjustice/analytical-platform#4271

This PR adds the deployment of a new terraform module which itself configures and deploys a lambda function which will sync Identity Center with EntraID groups prefixed with azure-aws-sso-

Terraform and function code here:
https://github.com/ministryofjustice/moj-terraform-scim-entra-id

Details on executing the function tests are here:
ministryofjustice/moj-terraform-scim-entra-id#6

@julialawrence julialawrence requested a review from a team as a code owner September 9, 2024 15:12
Copy link
Contributor

github-actions bot commented Sep 9, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY gitleaks yes no 0.56s
✅ REPOSITORY trivy yes no 9.93s
✅ TERRAFORM terraform-fmt 1 0 0.04s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@connormaglynn connormaglynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks Good To Me!

Just a few comments, some unrelated to the change 🙈

@julialawrence julialawrence merged commit ad38f72 into main Sep 9, 2024
5 of 6 checks passed
@julialawrence julialawrence deleted the feature/add-entra-id-lambda branch September 9, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants