Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing existing active cost allocation tags #971

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Importing existing active cost allocation tags #971

merged 2 commits into from
Sep 4, 2024

Conversation

julialawrence
Copy link
Contributor

Tracking story:
ministryofjustice/analytical-platform#5135

This PR imports into terraform existing cost allocation tags currently in use in the MOJ AWS Organisation.

The list was retrieved from AWS Cost Explorer and filtered for status.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY gitleaks yes no 0.59s
✅ REPOSITORY trivy yes no 10.23s
✅ TERRAFORM terraform-fmt 3 0 0.12s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@julialawrence julialawrence marked this pull request as ready for review September 4, 2024 19:50
@julialawrence julialawrence requested a review from a team as a code owner September 4, 2024 19:50
davidkelliott
davidkelliott approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@davidkelliott davidkelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice use of import and removed blocks

@julialawrence julialawrence merged commit 35cc15a into main Sep 4, 2024
5 of 6 checks passed
@julialawrence julialawrence deleted the import-existing-cost-allocation-tags branch September 4, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkelliott davidkelliott davidkelliott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julialawrence @davidkelliott