Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YJAF AWS account access to modernisation_platform_engineering #1078

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

AntonyBishop
Copy link
Contributor

👀 Purpose

  • This PR enables admin assess to Youth Justice Framework Management AWS account for modernisation-platform-engineering via SSO.

This is part of the handover of YJAF AWS access to Modernisation Platform.

♻️ What's changed

  • Add aws_organizations_account.youth_justice_framework_management.id to modernisation-platform-engineers

Notes

@AntonyBishop AntonyBishop requested review from a team as code owners January 17, 2025 13:08
Copy link
Contributor

github-actions bot commented Jan 17, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY gitleaks yes no 0.64s
✅ REPOSITORY trivy yes no 22.89s
✅ TERRAFORM terraform-fmt 1 0 0.05s
✅ TERRAFORM tflint yes no 14.14s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@@ -259,7 +259,8 @@ locals {
account_ids = [
aws_organizations_account.modernisation_platform.id,
aws_organizations_organization.default.master_account_id,
aws_organizations_account.organisation_security.id
aws_organizations_account.organisation_security.id,
aws_organizations_account.youth_justice_framework_management.id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but it's not admin permission set, but modernisation_platform_engineer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Have moved to the correct block. Resubmitting.

Copy link
Contributor

@ewastempel ewastempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AntonyBishop AntonyBishop merged commit c0015e6 into main Jan 17, 2025
6 checks passed
@AntonyBishop AntonyBishop deleted the AntonyBishop-patch-1 branch January 17, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants