Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CreateGroup to apply role #1066

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Adding CreateGroup to apply role #1066

merged 1 commit into from
Jan 6, 2025

Conversation

julialawrence
Copy link
Contributor

This PR failed to apply because Apply role doesn't have CreateGroup permissions in identitycenter

This PR adds it.

Work is related to

ministryofjustice/analytical-platform#6510

@julialawrence julialawrence requested a review from a team as a code owner January 6, 2025 17:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY gitleaks yes no 0.62s
✅ REPOSITORY trivy yes no 20.11s
✅ TERRAFORM terraform-fmt 1 0 0.04s
✅ TERRAFORM tflint yes no 11.89s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

connormaglynn
connormaglynn approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@connormaglynn connormaglynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks Good To Me!

@connormaglynn connormaglynn merged commit a1c1f98 into main Jan 6, 2025
7 checks passed
@connormaglynn connormaglynn deleted the fix/add-create-group-to-apply-role branch January 6, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connormaglynn connormaglynn connormaglynn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julialawrence @connormaglynn