Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Fix Slack Alert Failing by Only Using Commit Header #1037

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

connormaglynn
Copy link
Contributor

👀 Purpose

♻️ What's changed

  • Replace the current strategy of replacing new line characters (which didn't work) with only retrieving the commit message header for displaying in Slack

📝 Notes

  • Temporary workflow still there to test this in my testing channel 🧪

@connormaglynn connormaglynn requested a review from a team as a code owner November 21, 2024 09:21
@connormaglynn connormaglynn force-pushed the fix-slack-alert-failing branch from 4c23679 to 8f345c6 Compare November 21, 2024 09:21
Add some more lines

And even more lines!

And one more for good luck!

a
@connormaglynn connormaglynn force-pushed the fix-slack-alert-failing branch from 8f345c6 to 202eeb5 Compare November 21, 2024 09:22
Copy link
Contributor

github-actions bot commented Nov 21, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 3 0 0.05s
❌ REPOSITORY gitleaks yes 2 0.76s
✅ REPOSITORY trivy yes no 27.16s
✅ YAML prettier 3 0 0.46s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@ewastempel ewastempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@connormaglynn connormaglynn merged commit d96edcf into main Nov 22, 2024
5 of 6 checks passed
@connormaglynn connormaglynn deleted the fix-slack-alert-failing branch November 22, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants