Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction to code #1028

Merged
merged 9 commits into from
Nov 11, 2024
Merged

Correction to code #1028

merged 9 commits into from
Nov 11, 2024

Conversation

markgov
Copy link
Contributor

@markgov markgov commented Nov 8, 2024

Due to the last Pr not generating the results i was expecting i have gone back to the code and done some moving around. i have moved the s3 bucket name to under the parameters as well as the targetkey and targetvalues i have not set the target key block to use the parameter values instead of the target block.

@markgov markgov requested a review from a team as a code owner November 8, 2024 11:05
Copy link
Contributor

github-actions bot commented Nov 8, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ REPOSITORY gitleaks yes 1 0.93s
✅ REPOSITORY trivy yes no 15.7s
✅ TERRAFORM terraform-fmt 1 0 0.05s
✅ TERRAFORM tflint yes no 12.64s
⚠️ YAML prettier 1 1 0.49s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

connormaglynn
connormaglynn previously approved these changes Nov 8, 2024
@markgov
Copy link
Contributor Author

markgov commented Nov 8, 2024

New template also builds the ssm Association so there is no need for the extra resource to be created

@markgov markgov merged commit 3833747 into main Nov 11, 2024
5 of 6 checks passed
@markgov markgov deleted the poc/licence-manager-change branch November 11, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants