Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oracle license poc update #1020

Merged
merged 2 commits into from
Nov 5, 2024
Merged

oracle license poc update #1020

merged 2 commits into from
Nov 5, 2024

Conversation

markgov
Copy link
Contributor

@markgov markgov commented Oct 28, 2024

Found an issue with the cloud formation part of the code it is currently only being deployed to us-east-1 and not eu-west-1 London region added the provider section in and pointed it at a provider that is currently setup for London Region hopfully this should fix that part of the POC

@markgov markgov requested a review from a team as a code owner October 28, 2024 12:25
Copy link
Contributor

github-actions bot commented Oct 28, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY gitleaks yes no 0.71s
❌ REPOSITORY trivy yes 1 0.97s
⚠️ YAML prettier 1 1 0.55s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@@ -45,6 +45,7 @@ module "oracle_ec2_license_configurations" {

# Cloudformation stack for Oracle Database auto detection
resource "aws_cloudformation_stack" "oracleblts" {
provider = aws.original-session
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it fixes it.
Terraform plan reports:

No changes. Your infrastructure matches the configuration.

@@ -68,6 +69,7 @@ resource "aws_cloudformation_stack" "oracleblts" {

# Trigger automation
resource "aws_ssm_association" "license_manager" {
provider = aws.original-session
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it fixes it.
Terraform plan reports:

No changes. Your infrastructure matches the configuration.

@markgov markgov merged commit 6ac54a2 into main Nov 5, 2024
2 of 3 checks passed
@markgov markgov deleted the poc/licence-manager-change branch November 5, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants