Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve key_arn from alias and fix resource permission #1016

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

ASTRobinson
Copy link
Contributor

@ASTRobinson ASTRobinson commented Oct 16, 2024

This PR fixes an issue with DestinationBucketPermissions where the resource has been incorrectly structured with an additional arn:aws:s3::: prefix.

it also switches from using the kms key alias to key_arn by using aws_kms_alias data call.

Copy link
Contributor

github-actions bot commented Oct 16, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY gitleaks yes no 0.6s
✅ REPOSITORY trivy yes no 15.32s
✅ TERRAFORM terraform-fmt 2 0 0.1s
✅ TERRAFORM tflint yes no 11.86s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@ASTRobinson ASTRobinson changed the title Retrieve key arn from alias Retrieve key_arn from alias and fix resource permission Oct 17, 2024
@ASTRobinson ASTRobinson marked this pull request as ready for review October 17, 2024 11:14
@ASTRobinson ASTRobinson requested a review from a team as a code owner October 17, 2024 11:14
@ASTRobinson ASTRobinson merged commit 9e5a829 into main Oct 17, 2024
7 checks passed
@ASTRobinson ASTRobinson deleted the s3/retrieve-key-from-alias branch October 17, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants