Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛂 Preparing mojap-land for DataSync S3 replication #6104

Merged
merged 3 commits into from
Nov 14, 2024
Merged

🛂 Preparing mojap-land for DataSync S3 replication #6104

merged 3 commits into from
Nov 14, 2024

Conversation

jacobwoffenden
Copy link
Member

@jacobwoffenden jacobwoffenden commented Nov 13, 2024 •
edited
Loading

This pull request:

Signed-off-by: Jacob Woffenden [email protected]

@jacobwoffenden
Adding KMS key
e938c9a 
Amending mojap-land-dev

Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden jacobwoffenden self-assigned this Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Terraform Component 🧱: aws-analytical-platform-data-production-data-engineering-pipelines

Checkov 🛂: success

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/data-engineering-pipelines, Workflow: Terraform, Marker: aws-analytical-platform-data-production-data-engineering-pipelines_static_analysis

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Terraform Component 🧱: aws-analytical-platform-data-production-data-engineering-pipelines

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/data-engineering-pipelines, Workflow: Terraform, Marker: aws-analytical-platform-data-production-data-engineering-pipelines_plan

@jacobwoffenden
Add production
0f66925 
Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden
SCA SCA SCA
15dbaef 
Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden jacobwoffenden marked this pull request as ready for review November 13, 2024 17:34
@jacobwoffenden jacobwoffenden requested a review from a team as a code owner November 13, 2024 17:34
Gary-H9
Gary-H9 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@Gary-H9 Gary-H9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobwoffenden jacobwoffenden merged commit 60f9d4b into main Nov 14, 2024
17 checks passed
@jacobwoffenden jacobwoffenden deleted the feat/mojap-land-permissions branch November 14, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gary-H9 Gary-H9 Gary-H9 approved these changes

Assignees

@jacobwoffenden jacobwoffenden

Labels
override-static-analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobwoffenden @Gary-H9