Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AssumeRole Permissions to Control Panel Dev Role #5699

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

julialawrence
Copy link
Contributor

@julialawrence julialawrence commented Oct 16, 2024

Pull Request Objective

This piece of work is being tracked in
this
GitHub Issue.

This PR adds permissions to the Control Panel Development role to assume service roles in Compute development and test accounts to allow the Control Panel to manage LakeFormation and QuickSight-related assets in those accounts.

Checklist

Note

Each items should be checked. Skipping below checks could delay your PR review!

  • I have reviewed the style guide
    and ensured that my code complies with it
  • All checks have passed (or override label applied, if I've
    used the override-static-analysis label, I've explained why)
  • I have self-reviewed my code
  • I have reviewed the checks and can attest they're as expected

Additional Comments

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Terraform Component 🧱: aws-analytical-platform-development-cluster

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @julialawrence, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/cluster, Workflow: Terraform, Marker: aws-analytical-platform-development-cluster_plan

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Terraform Component 🧱: aws-analytical-platform-development-cluster

Checkov 🛂: success

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @julialawrence, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/cluster, Workflow: Terraform, Marker: aws-analytical-platform-development-cluster_static_analysis

@julialawrence julialawrence marked this pull request as ready for review October 16, 2024 11:17
@julialawrence julialawrence requested a review from a team as a code owner October 16, 2024 11:17
@julialawrence julialawrence merged commit c57c261 into main Oct 16, 2024
18 checks passed
@julialawrence julialawrence deleted the feature/add-assume-role-permissions-to-cp-role branch October 16, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants