Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find-moj-data-83/glossary #3449

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Find-moj-data-83/glossary #3449

merged 5 commits into from
Feb 26, 2024

Conversation

murdo-moj
Copy link
Contributor

@murdo-moj murdo-moj commented Feb 26, 2024

  • a get_glossary method in the datahub client and SearchClient
  • There's less flexibility with the query to get glossary terms, and I've set the default terms to return at 1000. I think this should be fine for our use case?
  • I haven't created a custom class for GlossaryTermMetadata since those classes eg TableMetadata are used on set methods, which we don't have any for glossary terms. Perhaps it would be more extensible to introduce that class now though?

@murdo-moj murdo-moj requested a review from a team February 26, 2024 11:24
Copy link
Contributor

@LavMatt LavMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - One minor comment but can be picked up another time if you prefer, as there are other methods that don't implement paginated results either

@murdo-moj murdo-moj merged commit 228847a into main Feb 26, 2024
16 checks passed
@murdo-moj murdo-moj deleted the find-moj-data-83/glossary branch February 26, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants