Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add Entra ID Auth0 connections #2351

Merged
merged 3 commits into from
Nov 14, 2023
Merged

✨ Add Entra ID Auth0 connections #2351

merged 3 commits into from
Nov 14, 2023

Conversation

jacobwoffenden
Copy link
Member

@jacobwoffenden jacobwoffenden commented Nov 14, 2023 •
edited
Loading

This pull request:

Manual steps:

  1. Created Azure App Registrations
  1. Created AWS Secrets Manager secrets in analytical-platform-management-production
  • auth0/${TENANT_NAME}/entra-id/tenant-id
  • auth0/${TENANT_NAME}/entra-id/client-id
  • auth0/${TENANT_NAME}/entra-id/client-secret
  1. Applied locally to validate

Signed-off-by: Jacob Woffenden [email protected]

Add Entra ID Auth0 connections
22cf9d8 
Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden jacobwoffenden self-assigned this Nov 14, 2023
@jacobwoffenden jacobwoffenden requested a review from a team November 14, 2023 12:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2023 •
edited
Loading

Terraform Component 🧱: auth0-ministryofjustice-data-platform-development

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: false

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/auth0/ministryofjustice-data-platform-development, Workflow: Terraform, Marker: auth0-ministryofjustice-data-platform-development_static_analysis

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2023 •
edited
Loading

Terraform Component 🧱: auth0-ministryofjustice-data-platform

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: false

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/auth0/ministryofjustice-data-platform, Workflow: Terraform, Marker: auth0-ministryofjustice-data-platform_static_analysis

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2023 •
edited
Loading

Terraform Component 🧱: auth0-ministryofjustice-data-platform

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/auth0/ministryofjustice-data-platform, Workflow: Terraform, Marker: auth0-ministryofjustice-data-platform_plan

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2023 •
edited
Loading

Terraform Component 🧱: auth0-ministryofjustice-data-platform-development

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/auth0/ministryofjustice-data-platform-development, Workflow: Terraform, Marker: auth0-ministryofjustice-data-platform-development_plan

julialawrence
julialawrence approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jacobwoffenden jacobwoffenden merged commit c1558ad into main Nov 14, 2023
15 checks passed
@jacobwoffenden jacobwoffenden deleted the feature/dpat-2231-auth0-entra-id branch November 14, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julialawrence julialawrence julialawrence approved these changes

@ymao2 ymao2 ymao2 approved these changes

Assignees

@jacobwoffenden jacobwoffenden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobwoffenden @ymao2 @julialawrence