♻️ Refactor GitHub Terraform component #1985

jacobwoffenden · 2023-10-20T00:37:53Z

This pull request Resolves #1884 and:

Adds GitHub component back into Terraform path-filter
Removes .github/workflows/configuration-workflow-terraform.yml as we no longer need to trigger those components
Adds Trivy back in to the SCA job
Updates GitHub Script to v6
Moves ap_migration_apps.json into terraform/aws/analytical-platform/oidc/configuration
Updates references to ap_migration_apps.json
Creates new module and structure for team management
Creates new module and structure for repository management
Creates new teams for enhanced AWS permissions model

Signed-off-by: Jacob Woffenden <[email protected]>

Split out CP access Signed-off-by: Jacob Woffenden <[email protected]>

github-actions · 2023-10-20T00:48:25Z

Terraform Component 🧱: `github-data-platform-2`

Checkov 🛂: `success`

Trivy 🛂: `success`

Static Analysis Override Label 🏷️: `false`

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/github/data-platform-2, Workflow: Terraform, Marker: github-data-platform-2_static_analysis

github-actions · 2023-10-20T00:49:04Z

Terraform Component 🧱: `github-data-platform-2`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/github/data-platform-2, Workflow: Terraform, Marker: github-data-platform-2_plan

Signed-off-by: Jacob Woffenden <[email protected]>

Add Trivy to process outcome step Signed-off-by: Jacob Woffenden <[email protected]>

Signed-off-by: Jacob Woffenden <[email protected]>

Add repository access Signed-off-by: Jacob Woffenden <[email protected]>

Added Data Engineering team Signed-off-by: Jacob Woffenden <[email protected]>

Signed-off-by: Jacob Woffenden <[email protected]>

michaeljcollinsuk · 2023-11-02T09:01:14Z

👍 Feels cleaner/easier to know where to look than existing implementation

further scope teams Signed-off-by: Jacob Woffenden <[email protected]>

Signed-off-by: Jacob Woffenden <[email protected]>

Move ap_migrations_apps.json to OIDC Remove application migration workflow Signed-off-by: Jacob Woffenden <[email protected]>

github-actions · 2023-11-02T13:00:50Z

Terraform Component 🧱: `github`

Checkov 🛂: `success`

Trivy 🛂: `success`

Static Analysis Override Label 🏷️: `true`

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/github, Workflow: Terraform, Marker: github_static_analysis

github-actions · 2023-11-02T13:01:01Z

Terraform Component 🧱: `aws-analytical-platform-oidc`

Checkov 🛂: `failure`

Trivy 🛂: `failure`

Static Analysis Override Label 🏷️: `true`

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/aws/analytical-platform/oidc, Workflow: Terraform, Marker: aws-analytical-platform-oidc_static_analysis

github-actions · 2023-11-02T13:01:20Z

Terraform Component 🧱: `aws-analytical-platform-oidc`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/aws/analytical-platform/oidc, Workflow: Terraform, Marker: aws-analytical-platform-oidc_plan

github-actions · 2023-11-02T13:01:54Z

Terraform Component 🧱: `github`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/github, Workflow: Terraform, Marker: github_plan

Signed-off-by: Jacob Woffenden <[email protected]>

Imported a lot of AP repos Import DP app template repo Added DP core infra team Signed-off-by: Jacob Woffenden <[email protected]>

Signed-off-by: Jacob Woffenden <[email protected]>

Add data-platform-control-panel repository Signed-off-by: Jacob Woffenden <[email protected]>

Archive AP Control Panel public fork Add Required checks on DP Control Panel Signed-off-by: Jacob Woffenden <[email protected]>

Signed-off-by: Jacob Woffenden <[email protected]>

Fix analytics-platform-control-panel-public Signed-off-by: Jacob Woffenden <[email protected]>

Signed-off-by: Jacob Woffenden <[email protected]>

jhpyke

lgtm

Signed-off-by: Jacob Woffenden <[email protected]>

* 📝 Update delete table swagger documentation * 📝 Update docs for presigned url and delete table * terraform(deps): bump terraform-aws-modules/iam/aws from 5.30.0 to 5.30.1 in /terraform/aws/analytical-platform-data-production/airflow (#2222) terraform(deps): bump terraform-aws-modules/iam/aws Bumps [terraform-aws-modules/iam/aws](https://github.com/terraform-aws-modules/terraform-aws-iam) from 5.30.0 to 5.30.1. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-iam/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-iam@v5.30.0...v5.30.1) --- updated-dependencies: - dependency-name: terraform-aws-modules/iam/aws dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * terraform(deps): bump terraform-aws-modules/iam/aws Bumps [terraform-aws-modules/iam/aws](https://github.com/terraform-aws-modules/terraform-aws-iam) from 5.30.0 to 5.30.1. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-iam/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-iam@v5.30.0...v5.30.1) --- updated-dependencies: - dependency-name: terraform-aws-modules/iam/aws dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump terraform-aws-modules/eks/aws Bumps [terraform-aws-modules/eks/aws](https://github.com/terraform-aws-modules/terraform-aws-eks) from 19.18.0 to 19.19.0. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-eks/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-eks@v19.18.0...v19.19.0) --- updated-dependencies: - dependency-name: terraform-aws-modules/eks/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * github-actions(deps): bump actions/dependency-review-action Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@6c5ccda...9f45b24) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * github-actions(deps): bump bridgecrewio/checkov-action Bumps [bridgecrewio/checkov-action](https://github.com/bridgecrewio/checkov-action) from 12.2559.0 to 12.2562.0. - [Release notes](https://github.com/bridgecrewio/checkov-action/releases) - [Commits](bridgecrewio/checkov-action@7930f52...2187810) --- updated-dependencies: - dependency-name: bridgecrewio/checkov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updated docs (#2241) * Updated docs * Added 400 response * ♻️ Refactor GitHub Terraform component (#1985) Signed-off-by: Jacob Woffenden <[email protected]> * terraform(deps): bump hashicorp/aws Bumps [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws) from 5.23.1 to 5.24.0. - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.23.1...v5.24.0) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump hashicorp/aws Bumps [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws) from 5.23.0 to 5.24.0. - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.23.0...v5.24.0) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump hashicorp/aws Bumps [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws) from 5.21.0 to 5.24.0. - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.21.0...v5.24.0) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * ✨ Ways of Working 2.0 (#2153) Signed-off-by: Jacob Woffenden <[email protected]> Co-authored-by: Jake H-P <[email protected]> Co-authored-by: Jacob Hamblin-Pyke <[email protected]> Co-authored-by: Michael Collins <[email protected]> * github-actions(deps): bump aquasecurity/trivy-action Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.13.1 to 0.14.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@f78e9ec...2b6a709) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * github-actions(deps): bump bridgecrewio/checkov-action Bumps [bridgecrewio/checkov-action](https://github.com/bridgecrewio/checkov-action) from 12.2562.0 to 12.2564.0. - [Release notes](https://github.com/bridgecrewio/checkov-action/releases) - [Commits](bridgecrewio/checkov-action@2187810...b74b473) --- updated-dependencies: - dependency-name: bridgecrewio/checkov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump integrations/github in /terraform/github Bumps [integrations/github](https://github.com/integrations/terraform-provider-github) from 5.41.0 to 5.42.0. - [Release notes](https://github.com/integrations/terraform-provider-github/releases) - [Changelog](https://github.com/integrations/terraform-provider-github/blob/main/CHANGELOG.md) - [Commits](integrations/terraform-provider-github@v5.41.0...v5.42.0) --- updated-dependencies: - dependency-name: integrations/github dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump terraform-aws-modules/iam/aws Bumps [terraform-aws-modules/iam/aws](https://github.com/terraform-aws-modules/terraform-aws-iam) from 5.30.0 to 5.30.1. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-iam/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-iam@v5.30.0...v5.30.1) --- updated-dependencies: - dependency-name: terraform-aws-modules/iam/aws dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update Data Product tech docs (#2177) * add versioning documentation * update spec and governance docs with optional implemented fields * add erb headers for previously added doc pages * Update docs/source/documentation/data-products/components/product-specification.html.md.erb * clarify `email` contact info definition * 📝 Update changelog & version --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Jacob Woffenden <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PriyaBasker23 <[email protected]> Co-authored-by: Jacob Woffenden <[email protected]> Co-authored-by: Jake H-P <[email protected]> Co-authored-by: Jacob Hamblin-Pyke <[email protected]> Co-authored-by: Michael Collins <[email protected]> Co-authored-by: Tom Webber <[email protected]>

Signed-off-by: Jacob Woffenden <[email protected]>

* 📝 Update delete table swagger documentation * 📝 Update docs for presigned url and delete table * terraform(deps): bump terraform-aws-modules/iam/aws from 5.30.0 to 5.30.1 in /terraform/aws/analytical-platform-data-production/airflow (#2222) terraform(deps): bump terraform-aws-modules/iam/aws Bumps [terraform-aws-modules/iam/aws](https://github.com/terraform-aws-modules/terraform-aws-iam) from 5.30.0 to 5.30.1. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-iam/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-iam@v5.30.0...v5.30.1) --- updated-dependencies: - dependency-name: terraform-aws-modules/iam/aws dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * terraform(deps): bump terraform-aws-modules/iam/aws Bumps [terraform-aws-modules/iam/aws](https://github.com/terraform-aws-modules/terraform-aws-iam) from 5.30.0 to 5.30.1. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-iam/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-iam@v5.30.0...v5.30.1) --- updated-dependencies: - dependency-name: terraform-aws-modules/iam/aws dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump terraform-aws-modules/eks/aws Bumps [terraform-aws-modules/eks/aws](https://github.com/terraform-aws-modules/terraform-aws-eks) from 19.18.0 to 19.19.0. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-eks/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-eks@v19.18.0...v19.19.0) --- updated-dependencies: - dependency-name: terraform-aws-modules/eks/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * github-actions(deps): bump actions/dependency-review-action Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@6c5ccda...9f45b24) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * github-actions(deps): bump bridgecrewio/checkov-action Bumps [bridgecrewio/checkov-action](https://github.com/bridgecrewio/checkov-action) from 12.2559.0 to 12.2562.0. - [Release notes](https://github.com/bridgecrewio/checkov-action/releases) - [Commits](bridgecrewio/checkov-action@7930f52...2187810) --- updated-dependencies: - dependency-name: bridgecrewio/checkov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updated docs (#2241) * Updated docs * Added 400 response * ♻️ Refactor GitHub Terraform component (#1985) Signed-off-by: Jacob Woffenden <[email protected]> * terraform(deps): bump hashicorp/aws Bumps [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws) from 5.23.1 to 5.24.0. - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.23.1...v5.24.0) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump hashicorp/aws Bumps [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws) from 5.23.0 to 5.24.0. - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.23.0...v5.24.0) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump hashicorp/aws Bumps [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws) from 5.21.0 to 5.24.0. - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.21.0...v5.24.0) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * ✨ Ways of Working 2.0 (#2153) Signed-off-by: Jacob Woffenden <[email protected]> Co-authored-by: Jake H-P <[email protected]> Co-authored-by: Jacob Hamblin-Pyke <[email protected]> Co-authored-by: Michael Collins <[email protected]> * github-actions(deps): bump aquasecurity/trivy-action Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.13.1 to 0.14.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@f78e9ec...2b6a709) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * github-actions(deps): bump bridgecrewio/checkov-action Bumps [bridgecrewio/checkov-action](https://github.com/bridgecrewio/checkov-action) from 12.2562.0 to 12.2564.0. - [Release notes](https://github.com/bridgecrewio/checkov-action/releases) - [Commits](bridgecrewio/checkov-action@2187810...b74b473) --- updated-dependencies: - dependency-name: bridgecrewio/checkov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump integrations/github in /terraform/github Bumps [integrations/github](https://github.com/integrations/terraform-provider-github) from 5.41.0 to 5.42.0. - [Release notes](https://github.com/integrations/terraform-provider-github/releases) - [Changelog](https://github.com/integrations/terraform-provider-github/blob/main/CHANGELOG.md) - [Commits](integrations/terraform-provider-github@v5.41.0...v5.42.0) --- updated-dependencies: - dependency-name: integrations/github dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump terraform-aws-modules/iam/aws Bumps [terraform-aws-modules/iam/aws](https://github.com/terraform-aws-modules/terraform-aws-iam) from 5.30.0 to 5.30.1. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-iam/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-iam@v5.30.0...v5.30.1) --- updated-dependencies: - dependency-name: terraform-aws-modules/iam/aws dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update Data Product tech docs (#2177) * add versioning documentation * update spec and governance docs with optional implemented fields * add erb headers for previously added doc pages * Update docs/source/documentation/data-products/components/product-specification.html.md.erb * clarify `email` contact info definition * 📝 Update changelog & version --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Jacob Woffenden <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PriyaBasker23 <[email protected]> Co-authored-by: Jacob Woffenden <[email protected]> Co-authored-by: Jake H-P <[email protected]> Co-authored-by: Jacob Hamblin-Pyke <[email protected]> Co-authored-by: Michael Collins <[email protected]> Co-authored-by: Tom Webber <[email protected]>

* 🚧 Delete table metadata versioning * 🚚 Move delete glue table funcion to its own base module * ✅ Refactor delete table tests * 🔥 Refactor and remove code to VersionCreator class * ✨ Now handles removing tables, data files, versioning and copying * ✨ Added new and refactored utility functions * 🔥 Remove unused fixture * ♻️ Simplify update_metadata_remove_schemas * 👔 Validate on schema list rather than presence of schema key * ✅ Add test to validate deletion of schema.json file * 🔊 Update success message * 🔥 Remove create table function as not needed at this time * ✅ Updated spec folder version * 📝 Update python base change log and config with new version * 🧪 Fix python base tests to use s3_client * ✅ Add tests for VersionCreator.update_metadata_remove_schema method * 📝 Update change logs and bump delete table version * ➕ Add pyparsing===3.1.1 * Update delete_table.py update success response with format_response_json * ✅ Update test to reflect success response object change * 🚑 Update repository name * 🔖 Update changelog and increase version * 📝 Update change logs and bump delete table version * ♻️ Move delete_all_element_version_data_files to versioning module * terraform(deps): bump terraform-aws-modules/iam/aws from 5.30.0 to 5.30.1 in /terraform/aws/analytical-platform-data-production/airflow (#2222) terraform(deps): bump terraform-aws-modules/iam/aws Bumps [terraform-aws-modules/iam/aws](https://github.com/terraform-aws-modules/terraform-aws-iam) from 5.30.0 to 5.30.1. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-iam/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-iam@v5.30.0...v5.30.1) --- updated-dependencies: - dependency-name: terraform-aws-modules/iam/aws dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * terraform(deps): bump terraform-aws-modules/iam/aws Bumps [terraform-aws-modules/iam/aws](https://github.com/terraform-aws-modules/terraform-aws-iam) from 5.30.0 to 5.30.1. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-iam/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-iam@v5.30.0...v5.30.1) --- updated-dependencies: - dependency-name: terraform-aws-modules/iam/aws dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump terraform-aws-modules/eks/aws Bumps [terraform-aws-modules/eks/aws](https://github.com/terraform-aws-modules/terraform-aws-eks) from 19.18.0 to 19.19.0. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-eks/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-eks@v19.18.0...v19.19.0) --- updated-dependencies: - dependency-name: terraform-aws-modules/eks/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * github-actions(deps): bump actions/dependency-review-action Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@6c5ccda...9f45b24) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * github-actions(deps): bump bridgecrewio/checkov-action Bumps [bridgecrewio/checkov-action](https://github.com/bridgecrewio/checkov-action) from 12.2559.0 to 12.2562.0. - [Release notes](https://github.com/bridgecrewio/checkov-action/releases) - [Commits](bridgecrewio/checkov-action@7930f52...2187810) --- updated-dependencies: - dependency-name: bridgecrewio/checkov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updated docs (#2241) * Updated docs * Added 400 response * ♻️ Refactor GitHub Terraform component (#1985) Signed-off-by: Jacob Woffenden <[email protected]> * terraform(deps): bump hashicorp/aws Bumps [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws) from 5.23.1 to 5.24.0. - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.23.1...v5.24.0) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump hashicorp/aws Bumps [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws) from 5.23.0 to 5.24.0. - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.23.0...v5.24.0) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump hashicorp/aws Bumps [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws) from 5.21.0 to 5.24.0. - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.21.0...v5.24.0) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * ✨ Ways of Working 2.0 (#2153) Signed-off-by: Jacob Woffenden <[email protected]> Co-authored-by: Jake H-P <[email protected]> Co-authored-by: Jacob Hamblin-Pyke <[email protected]> Co-authored-by: Michael Collins <[email protected]> * github-actions(deps): bump aquasecurity/trivy-action Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.13.1 to 0.14.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@f78e9ec...2b6a709) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * github-actions(deps): bump bridgecrewio/checkov-action Bumps [bridgecrewio/checkov-action](https://github.com/bridgecrewio/checkov-action) from 12.2562.0 to 12.2564.0. - [Release notes](https://github.com/bridgecrewio/checkov-action/releases) - [Commits](bridgecrewio/checkov-action@2187810...b74b473) --- updated-dependencies: - dependency-name: bridgecrewio/checkov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump integrations/github in /terraform/github Bumps [integrations/github](https://github.com/integrations/terraform-provider-github) from 5.41.0 to 5.42.0. - [Release notes](https://github.com/integrations/terraform-provider-github/releases) - [Changelog](https://github.com/integrations/terraform-provider-github/blob/main/CHANGELOG.md) - [Commits](integrations/terraform-provider-github@v5.41.0...v5.42.0) --- updated-dependencies: - dependency-name: integrations/github dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump terraform-aws-modules/iam/aws Bumps [terraform-aws-modules/iam/aws](https://github.com/terraform-aws-modules/terraform-aws-iam) from 5.30.0 to 5.30.1. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-iam/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-iam@v5.30.0...v5.30.1) --- updated-dependencies: - dependency-name: terraform-aws-modules/iam/aws dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update Data Product tech docs (#2177) * add versioning documentation * update spec and governance docs with optional implemented fields * add erb headers for previously added doc pages * Update docs/source/documentation/data-products/components/product-specification.html.md.erb * clarify `email` contact info definition * Swagger docs update (#2250) * 📝 Update delete table swagger documentation * 📝 Update docs for presigned url and delete table * terraform(deps): bump terraform-aws-modules/iam/aws from 5.30.0 to 5.30.1 in /terraform/aws/analytical-platform-data-production/airflow (#2222) terraform(deps): bump terraform-aws-modules/iam/aws Bumps [terraform-aws-modules/iam/aws](https://github.com/terraform-aws-modules/terraform-aws-iam) from 5.30.0 to 5.30.1. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-iam/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-iam@v5.30.0...v5.30.1) --- updated-dependencies: - dependency-name: terraform-aws-modules/iam/aws dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * terraform(deps): bump terraform-aws-modules/iam/aws Bumps [terraform-aws-modules/iam/aws](https://github.com/terraform-aws-modules/terraform-aws-iam) from 5.30.0 to 5.30.1. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-iam/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-iam@v5.30.0...v5.30.1) --- updated-dependencies: - dependency-name: terraform-aws-modules/iam/aws dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump terraform-aws-modules/eks/aws Bumps [terraform-aws-modules/eks/aws](https://github.com/terraform-aws-modules/terraform-aws-eks) from 19.18.0 to 19.19.0. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-eks/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-eks@v19.18.0...v19.19.0) --- updated-dependencies: - dependency-name: terraform-aws-modules/eks/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * github-actions(deps): bump actions/dependency-review-action Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@6c5ccda...9f45b24) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * github-actions(deps): bump bridgecrewio/checkov-action Bumps [bridgecrewio/checkov-action](https://github.com/bridgecrewio/checkov-action) from 12.2559.0 to 12.2562.0. - [Release notes](https://github.com/bridgecrewio/checkov-action/releases) - [Commits](bridgecrewio/checkov-action@7930f52...2187810) --- updated-dependencies: - dependency-name: bridgecrewio/checkov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updated docs (#2241) * Updated docs * Added 400 response * ♻️ Refactor GitHub Terraform component (#1985) Signed-off-by: Jacob Woffenden <[email protected]> * terraform(deps): bump hashicorp/aws Bumps [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws) from 5.23.1 to 5.24.0. - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.23.1...v5.24.0) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump hashicorp/aws Bumps [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws) from 5.23.0 to 5.24.0. - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.23.0...v5.24.0) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump hashicorp/aws Bumps [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws) from 5.21.0 to 5.24.0. - [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-aws@v5.21.0...v5.24.0) --- updated-dependencies: - dependency-name: hashicorp/aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * ✨ Ways of Working 2.0 (#2153) Signed-off-by: Jacob Woffenden <[email protected]> Co-authored-by: Jake H-P <[email protected]> Co-authored-by: Jacob Hamblin-Pyke <[email protected]> Co-authored-by: Michael Collins <[email protected]> * github-actions(deps): bump aquasecurity/trivy-action Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.13.1 to 0.14.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@f78e9ec...2b6a709) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * github-actions(deps): bump bridgecrewio/checkov-action Bumps [bridgecrewio/checkov-action](https://github.com/bridgecrewio/checkov-action) from 12.2562.0 to 12.2564.0. - [Release notes](https://github.com/bridgecrewio/checkov-action/releases) - [Commits](bridgecrewio/checkov-action@2187810...b74b473) --- updated-dependencies: - dependency-name: bridgecrewio/checkov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump integrations/github in /terraform/github Bumps [integrations/github](https://github.com/integrations/terraform-provider-github) from 5.41.0 to 5.42.0. - [Release notes](https://github.com/integrations/terraform-provider-github/releases) - [Changelog](https://github.com/integrations/terraform-provider-github/blob/main/CHANGELOG.md) - [Commits](integrations/terraform-provider-github@v5.41.0...v5.42.0) --- updated-dependencies: - dependency-name: integrations/github dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * terraform(deps): bump terraform-aws-modules/iam/aws Bumps [terraform-aws-modules/iam/aws](https://github.com/terraform-aws-modules/terraform-aws-iam) from 5.30.0 to 5.30.1. - [Release notes](https://github.com/terraform-aws-modules/terraform-aws-iam/releases) - [Changelog](https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/CHANGELOG.md) - [Commits](terraform-aws-modules/terraform-aws-iam@v5.30.0...v5.30.1) --- updated-dependencies: - dependency-name: terraform-aws-modules/iam/aws dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update Data Product tech docs (#2177) * add versioning documentation * update spec and governance docs with optional implemented fields * add erb headers for previously added doc pages * Update docs/source/documentation/data-products/components/product-specification.html.md.erb * clarify `email` contact info definition * 📝 Update changelog & version --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Jacob Woffenden <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PriyaBasker23 <[email protected]> Co-authored-by: Jacob Woffenden <[email protected]> Co-authored-by: Jake H-P <[email protected]> Co-authored-by: Jacob Hamblin-Pyke <[email protected]> Co-authored-by: Michael Collins <[email protected]> Co-authored-by: Tom Webber <[email protected]> * Dp 1797 update athena_load to use existing schema for curated table (#2156) * Use existing schema for curated table if exists * test load handler with and without existing schema * refactor athena_load_handler tests * database name for DataProductElement.curated_data_table includes latest major version * trim schema table desc and col comment to glue limits * clear defaults from glue schema template * add `database_name` to `BaseJsonSchema` - used in glue schema * add `database_name` to `DataProductElement` - used in `curated_data_table` * Check csv for issues even if schema is not available (#2205) * Check csv for issues even if schema is not available If the schema is available, we can validate column types. However, even if we don't have a schema, we need to check that the csv looks parsable and does not contain embedded newlines. * Changelog and versioning * Use the correct name for logging to s3 * Add data product name to the logger and update to latest base image in reload/resync lambdas (#2211) * Add data product name to the logger where missing * Upgrade to latest base image This picks up the new path format changes. * 🚑 Add `limit-severities-for-sarif` option to `aquasecurity/trivy-action` (#2254) Signed-off-by: Jacob Woffenden <[email protected]> * Remove delete table schema references (#2257) * 🔥 Remove delete table schema references * 📝 Update changelog and config.json for v1.0.11 * fix container dockerfiles: `LAMDA_TASK_ROOT` -> `LAMBDA_TASK_ROOT` (#2253) * fix container dockerfiles: `LAMDA_TASK_ROOT` -> `LAMBDA_TASK_ROOT` * update `evaluate_checks` workflow error reporting * Return text/plain preview instead of application/json (#2260) Currently, API gateway is returning the response as a JSON encoded string, e.g. `"| col_0 | col_1 | col_2 | col_3 | extraction_timestamp |\n| 0.1915194503788923 | 0.3648859839013723 | 0.0598092227798519 | 0.2852509600245098 | 20231023T144052Z |\n| 0.7853585837137692 | 0.3688240060019745 | 0.6748809435823302 | 0.19567517866589823 | 20231023T144052Z |\n| 0.7799758081188035 | 0.9331401019825216 | 0.5946247799344488 | 0.38231745203150647 | 20231023T144052Z |\n| 0.2725926052826416 | 0.6513781432265774 | 0.5333101629987506 | 0.05387368514623658 | 20231023T144052Z |\n| 0.2764642551430967 | 0.3972025777261542 | 0.04332406269480349 | 0.45164840826085906 | 20231023T144052Z |\n| 0.6221087710398319 | 0.6153961784334937 | 0.18428708381381365 | 0.624916705305911 | 20231023T144052Z |\n| 0.4377277390071145 | 0.07538124164297655 | 0.04735527880151513 | 0.47809379567067456 | 20231023T144052Z |\n| 0.8018721775350193 | 0.7887301429407455 | 0.5614330800633979 | 0.9820047415219545 | 20231023T144052Z |\n| 0.9581393536837052 | 0.31683612216887125 | 0.329668445620915 | 0.12394270048696299 | 20231023T144052Z |\n| 0.8759326347420947 | 0.5680986526260692 | 0.5029668331126184 | 0.1193808979262484 | 20231023T144052Z |\n"` (Note the enclosing quote characters and literal \n instead of line breaks). We actually want this to be plain text, formatted so that it displays nicely on a console. * ✨ Add `ONBUILD` to DaaP Python Base (#2256) Signed-off-by: Jacob Woffenden <[email protected]> * fix and update get_schema lambda (#2261) * fix get schema * use DataProductSchema to fetch schema * github-actions(deps): bump bridgecrewio/checkov-action Bumps [bridgecrewio/checkov-action](https://github.com/bridgecrewio/checkov-action) from 12.2564.0 to 12.2566.0. - [Release notes](https://github.com/bridgecrewio/checkov-action/releases) - [Commits](bridgecrewio/checkov-action@b74b473...61c04ed) --- updated-dependencies: - dependency-name: bridgecrewio/checkov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * github-actions(deps): bump actions/dependency-review-action Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@9f45b24...fde92ac) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * 🛂 Adds `ap-rshiny-notesbook` to ECR trust (#2265) Signed-off-by: Jacob Woffenden <[email protected]> * 📝 Update python base change log and config with new version * 📝 Update change logs and bump delete table version * 📝 Update change logs and bump delete table version * 📌 Update python base image version --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Jacob Woffenden <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PriyaBasker23 <[email protected]> Co-authored-by: Jacob Woffenden <[email protected]> Co-authored-by: Jake H-P <[email protected]> Co-authored-by: Jacob Hamblin-Pyke <[email protected]> Co-authored-by: Michael Collins <[email protected]> Co-authored-by: Tom Webber <[email protected]> Co-authored-by: Mat <[email protected]>

Initial Data Platform teams

f3e6106

Signed-off-by: Jacob Woffenden <[email protected]>

jacobwoffenden self-assigned this Oct 20, 2023

Add component to path-filter

05f9503

Split out CP access Signed-off-by: Jacob Woffenden <[email protected]>

Jacob Woffenden added 3 commits October 20, 2023 00:56

Rename CP access team

c03ba30

Signed-off-by: Jacob Woffenden <[email protected]>

Remove unused locals

959e0e4

Signed-off-by: Jacob Woffenden <[email protected]>

BONUS: Trivy

1f340a5

Signed-off-by: Jacob Woffenden <[email protected]>

github-actions bot added the github-workflow Pull requests that update workflows label Oct 20, 2023

Jacob Woffenden added 8 commits October 20, 2023 01:08

use scanners

f53783c

Signed-off-by: Jacob Woffenden <[email protected]>

switch to config scan

8db9b6f

Signed-off-by: Jacob Woffenden <[email protected]>

Testing bad code

e9c32a2

Signed-off-by: Jacob Woffenden <[email protected]>

Update github-script

ec4efc3

Add Trivy to process outcome step Signed-off-by: Jacob Woffenden <[email protected]>

Removing comment

3ae07dc

Signed-off-by: Jacob Woffenden <[email protected]>

trivy ignore public repo

14974d2

Signed-off-by: Jacob Woffenden <[email protected]>

Add data-platform repo

9392519

Signed-off-by: Jacob Woffenden <[email protected]>

Remove Terrascan ignore

1a1e987

Signed-off-by: Jacob Woffenden <[email protected]>

jacobwoffenden mentioned this pull request Oct 23, 2023

Remove Parminder and Samuel for JML #2025

Closed

Jacob Woffenden added 9 commits October 23, 2023 16:18

Add AP, DE and DP teams

3493cd5

Add repository access Signed-off-by: Jacob Woffenden <[email protected]>

Added Analytical Platform access teams

f2aa7e1

Added Data Engineering team Signed-off-by: Jacob Woffenden <[email protected]>

bump providers

f48217d

Signed-off-by: Jacob Woffenden <[email protected]>

Add branch protection for main

bc9e2d4

Signed-off-by: Jacob Woffenden <[email protected]>

Merge branch 'main' into refactor/github-management

5bc59d2

Add and archive analytics-platform-infrastructure

a9fcdf1

Signed-off-by: Jacob Woffenden <[email protected]>

Merge branch 'main' into refactor/github-management

74549ad

Add checkov and trivy skips

acaf1fb

Signed-off-by: Jacob Woffenden <[email protected]>

import some repos

2c25738

Signed-off-by: Jacob Woffenden <[email protected]>

Jacob Woffenden added 2 commits November 2, 2023 11:48

disable security on archived repos

b200e18

further scope teams Signed-off-by: Jacob Woffenden <[email protected]>

Add MI Platform

a56e695

Signed-off-by: Jacob Woffenden <[email protected]>

Replace references to data-platform-2

7d04a1b

Move ap_migrations_apps.json to OIDC Remove application migration workflow Signed-off-by: Jacob Woffenden <[email protected]>

Jacob Woffenden added 7 commits November 2, 2023 13:02

Merge branch 'main' into refactor/github-management

b8a1964

Add kraihanmoj

95bd80e

Signed-off-by: Jacob Woffenden <[email protected]>

Set template to a variable

497ba36

Imported a lot of AP repos Import DP app template repo Added DP core infra team Signed-off-by: Jacob Woffenden <[email protected]>

Added andrewc-moj

317c5d4

Signed-off-by: Jacob Woffenden <[email protected]>

Merge branch 'main' into refactor/github-management

71020a2

Bump providers

78773a0

Add data-platform-control-panel repository Signed-off-by: Jacob Woffenden <[email protected]>

Merge branch 'main' into refactor/github-management

143e67f

jacobwoffenden marked this pull request as ready for review November 3, 2023 16:06

jacobwoffenden requested a review from a team November 3, 2023 16:06

Jacob Woffenden added 2 commits November 6, 2023 12:03

Set AP Control Panel to public

d2e0ca8

Archive AP Control Panel public fork Add Required checks on DP Control Panel Signed-off-by: Jacob Woffenden <[email protected]>

Merge branch 'main' into refactor/github-management

6fd32bd

jacobwoffenden added the override-static-analysis label Nov 6, 2023

Jacob Woffenden added 4 commits November 6, 2023 23:35

Retire AP control panel fork

6bf1b28

Signed-off-by: Jacob Woffenden <[email protected]>

Add pricemg

bf6e93c

Fix analytics-platform-control-panel-public Signed-off-by: Jacob Woffenden <[email protected]>

update dependabot and path-filters

6069fa5

Signed-off-by: Jacob Woffenden <[email protected]>

Merge branch 'main' into refactor/github-management

2ce6935

jhpyke approved these changes Nov 7, 2023

View reviewed changes

jacobwoffenden merged commit 7f20cc2 into main Nov 7, 2023

jacobwoffenden deleted the refactor/github-management branch November 7, 2023 10:02

mitchdawson1982 pushed a commit that referenced this pull request Nov 7, 2023

♻️ Refactor GitHub Terraform component (#1985)

448c41c

Signed-off-by: Jacob Woffenden <[email protected]>

mitchdawson1982 pushed a commit that referenced this pull request Nov 8, 2023

♻️ Refactor GitHub Terraform component (#1985)

5152f96

Signed-off-by: Jacob Woffenden <[email protected]>

jacobwoffenden mentioned this pull request Nov 14, 2023

🕵️ Keep up-to-date with the deprecation of tfsec #887

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

♻️ Refactor GitHub Terraform component #1985

♻️ Refactor GitHub Terraform component #1985

jacobwoffenden commented Oct 20, 2023 •

edited

Loading

github-actions bot commented Oct 20, 2023 •

edited

Loading

github-actions bot commented Oct 20, 2023 •

edited

Loading

michaeljcollinsuk commented Nov 2, 2023

github-actions bot commented Nov 2, 2023 •

edited

Loading

github-actions bot commented Nov 2, 2023 •

edited

Loading

github-actions bot commented Nov 2, 2023 •

edited

Loading

github-actions bot commented Nov 2, 2023 •

edited

Loading

jhpyke left a comment

♻️ Refactor GitHub Terraform component #1985

♻️ Refactor GitHub Terraform component #1985

Conversation

jacobwoffenden commented Oct 20, 2023 • edited Loading

github-actions bot commented Oct 20, 2023 • edited Loading

Terraform Component 🧱: github-data-platform-2

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: false

github-actions bot commented Oct 20, 2023 • edited Loading

Terraform Component 🧱: github-data-platform-2

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

michaeljcollinsuk commented Nov 2, 2023

github-actions bot commented Nov 2, 2023 • edited Loading

Terraform Component 🧱: github

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: true

github-actions bot commented Nov 2, 2023 • edited Loading

Terraform Component 🧱: aws-analytical-platform-oidc

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

github-actions bot commented Nov 2, 2023 • edited Loading

Terraform Component 🧱: aws-analytical-platform-oidc

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

github-actions bot commented Nov 2, 2023 • edited Loading

Terraform Component 🧱: github

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

jhpyke left a comment

Choose a reason for hiding this comment

jacobwoffenden commented Oct 20, 2023 •

edited

Loading

github-actions bot commented Oct 20, 2023 •

edited

Loading

Terraform Component 🧱: `github-data-platform-2`

Checkov 🛂: `success`

Trivy 🛂: `success`

Static Analysis Override Label 🏷️: `false`

github-actions bot commented Oct 20, 2023 •

edited

Loading

Terraform Component 🧱: `github-data-platform-2`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`

github-actions bot commented Nov 2, 2023 •

edited

Loading

Terraform Component 🧱: `github`

Checkov 🛂: `success`

Trivy 🛂: `success`

Static Analysis Override Label 🏷️: `true`

github-actions bot commented Nov 2, 2023 •

edited

Loading

Terraform Component 🧱: `aws-analytical-platform-oidc`

Checkov 🛂: `failure`

Trivy 🛂: `failure`

Static Analysis Override Label 🏷️: `true`

github-actions bot commented Nov 2, 2023 •

edited

Loading

Terraform Component 🧱: `aws-analytical-platform-oidc`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`

github-actions bot commented Nov 2, 2023 •

edited

Loading

Terraform Component 🧱: `github`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`