Add get-schema lambda #1793
Add get-schema lambda #1793
Conversation
MatMoore
changed the title
MatMoore
force-pushed
the
dpl-1659-display-schema-lambda
branch
2 times, most recently
from
96d8228 to
281dd49
Compare
This will serve the /data-product/{data-product}/table/{table-name}
endpoint.
This will eventually replace daap-get-glue-metadata, since the source of
truth for a schema is now s3, rather than glue. Once this endpoint has
been successfully deployed, I will remove daap-get-glue-metadata.
MatMoore
force-pushed
the
dpl-1659-display-schema-lambda
branch
from
281dd49 to
da57623
Compare
|
This link is useful to check your ECR repo has the image in once you've merged (assume shared services from one of the MP accounts) https://user-guide.modernisation-platform.service.justice.gov.uk/user-guide/member-read-only-core-accounts.html#switching-roles |
|
Is your plan to merge this returning the fully registered schema, including the information that's probably not very interesting to a user and then refine once my create schema PRs are merged? Looks good other than one minor comment |
Yeah that's the plan - if I merge it now I can work on the terraform in the meantime |
This is an initial implementation of the lambda that will serve the
/data-product/{data-product}/table/{table-name}endpoint. Once this is in, I can define the API gateway part in terraform.ministryofjustice/modernisation-platform#5155 needs to be merged before this one.Next steps
This will eventually replace daap-get-glue-metadata, since the source of truth for a schema is now s3, rather than glue. Once this endpoint has been successfully deployed, I will remove daap-get-glue-metadata.
The response is not finalised yet - this endpoint should be consistent with #1194 so we are thinking of simplifying the schema to just the essential parts instead of returning the full glue metadata. (See https://github.com/ministryofjustice/modernisation-platform-environments/blob/dpl-1194-create-table-schema/terraform/environments/data-platform/data-product-table-schema-json-schema/v1.0.0/moj_data_product_table_spec.json).