Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tfsec #1647

Closed
wants to merge 13 commits into from
Closed

Remove tfsec #1647

wants to merge 13 commits into from

Conversation

Emterry
Copy link
Contributor

@Emterry Emterry commented Sep 25, 2023

after some trial and error decided to remove tfsec from this workflow and place its replacement trivy into a new separate workflow

@github-actions github-actions bot added the github-workflow Pull requests that update workflows label Sep 25, 2023
@github-actions
Copy link
Contributor

Terraform Component 🧱: ``

Checkov 🛂: failure

tfsec 🛂: ``

Static Analysis Override Label 🏷️: true

Pusher: @Emterry, Action: pull_request, Working Directory: ``, Workflow: .github/workflows/reusable-workflow-terraform.yml, Marker: `_static_analysis`

@Emterry Emterry force-pushed the trivy branch 2 times, most recently from 9f6810a to 1b94da4 Compare September 25, 2023 09:11
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Terraform Component 🧱: pagerduty

Checkov 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @Emterry, Action: pull_request, Working Directory: terraform/pagerduty, Workflow: Terraform, Marker: pagerduty_static_analysis

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Terraform Component 🧱: pagerduty

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @Emterry, Action: pull_request, Working Directory: terraform/pagerduty, Workflow: Terraform, Marker: pagerduty_plan

@Emterry Emterry force-pushed the trivy branch 4 times, most recently from dde5bdf to ea61b14 Compare September 25, 2023 11:00
@Emterry Emterry force-pushed the trivy branch 6 times, most recently from f1316b7 to 4078410 Compare September 25, 2023 12:55
@Emterry Emterry marked this pull request as ready for review September 25, 2023 15:02
@Emterry Emterry requested a review from a team September 25, 2023 15:02
@Emterry Emterry marked this pull request as draft September 25, 2023 15:21
@Emterry Emterry marked this pull request as ready for review September 27, 2023 09:19
@Emterry Emterry changed the title replace tfsec with trivy Remove tfsec Sep 27, 2023
Comment on lines -161 to -163
if [[ "${failBuild}" == "true" ]]; then
exit 1
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should remain, it controls the output

@Emterry Emterry closed this Sep 28, 2023
@jacobwoffenden jacobwoffenden deleted the trivy branch May 9, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-workflow Pull requests that update workflows override-static-analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants