Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔐 Add Azure app secrets to be read by Control Panel #3868

Closed
1 of 2 tasks
Tracked by #2955
michaeljcollinsuk opened this issue Mar 26, 2024 · 2 comments
Closed
1 of 2 tasks
Tracked by #2955

🔐 Add Azure app secrets to be read by Control Panel #3868

michaeljcollinsuk opened this issue Mar 26, 2024 · 2 comments
Labels

Comments

@michaeljcollinsuk
Copy link
Contributor

michaeljcollinsuk commented Mar 26, 2024

User Story

As a AP developer
I need to be able to store Azure app secrets
So that they are accessible in the Control Panel

Value / Purpose

Required in order to implement #3605

Useful Contacts

@michaeljcollinsuk @julialawrence

User Types

AP devs/engineers

Hypothesis

No response

Proposal

We need to store Azure app secrets somewhere that allows them to be stored safely and accessible in the Control Panel.

We will use AWS secrets manager to store them and read from in the Control Panel

Additional Information

Related ticket #3178

Definition of Done

  • Secrets stored in the Secrets Manager
  • A new release of Control Panel is deployed where the secrets are accessible
@michaeljcollinsuk
Copy link
Contributor Author

michaeljcollinsuk commented Apr 8, 2024

5/4/24
A new kubectl secret control-panel-azure was applied manually using kubectl --namespace cpanel apply -f secret.yaml.
Related PR to update the helm chart to add env vars for the secrets https://github.com/ministryofjustice/analytics-platform-helm-charts/pull/744

@jamesstottmoj also tried to add a new secret in the old method, via Flux, however this failed to update the secret.

TODO
Need to release a new version of the helm chart that also adds the AZURE_CLIENT_SECRET env var

@michaeljcollinsuk
Copy link
Contributor Author

8/4/24
Updated the control-panel-azure secret to include the client secret.
Helm chart released with AZURE_CLIENT_SECRET env added - implemented in PR

@github-project-automation github-project-automation bot moved this from 🚀 In Progress to 🎉 Done in Analytical Platform Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

1 participant