Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE 🧐 Figure out how env secrets are added to Control Panel via Flux #3178

Closed
2 tasks
michaeljcollinsuk opened this issue Feb 2, 2024 · 3 comments
Closed
2 tasks
Labels
data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools enhancement enhancing an existing feature stale

Comments

@michaeljcollinsuk
Copy link
Contributor

michaeljcollinsuk commented Feb 2, 2024

User Story

As developers and engineers we are currently uncertain about how environmental secrets are added to the deployment

Value / Purpose

While we still use flux to deploy control panel, we need to be able to add env secrets as required. At the moment we are avoiding adding secrets this way and it is not sustainable.

Useful Contacts

@michaeljcollinsuk

User Types

Developers and platform engineers

Hypothesis

Once we understand and document this process, we will be able to add secrets again.

Proposal

Spend time investigating the existing process for adding env secrets to Control Panel via Flux. Recent attempts to add a secret were unsuccessful, see https://github.com/moj-analytical-services/analytical-platform-flux/pull/1224 for more context and changes that were attempted.

Timebox this to 2 dev-days and if we're unable, raise 2 stories:

  1. Move deployment of Control Panel out of Flux
  2. Retire Flux as a deployment tool

Additional Information

Slack discussions about the changes attempted

  1. https://mojdt.slack.com/archives/C04M8224WCV/p1706724198310519
  2. https://mojdt.slack.com/archives/C04M8224WCV/p1706793021693519

See old PR by Yikang which appears to have cleaned up env secrets https://github.com/moj-analytical-services/analytical-platform-flux/pull/1067

Definition of Done

  • Secrets can be added/updated or
  • Follow-on stories raised.
@michaeljcollinsuk michaeljcollinsuk added the enhancement enhancing an existing feature label Feb 2, 2024
@michaeljcollinsuk michaeljcollinsuk added the data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools label Feb 2, 2024
@michaeljcollinsuk michaeljcollinsuk changed the title [gitmoji] Figure out how env secrets are added to Control Panel via Flux 🧐 Figure out how env secrets are added to Control Panel via Flux Feb 2, 2024
@EO510 EO510 changed the title 🧐 Figure out how env secrets are added to Control Panel via Flux SPIKE 🧐 Figure out how env secrets are added to Control Panel via Flux Feb 6, 2024
@jacobwoffenden jacobwoffenden moved this to 👀 TODO in Analytical Platform Feb 15, 2024
Copy link
Contributor

github-actions bot commented Apr 7, 2024

This issue is being marked as stale because it has been open for 60 days with no activity. Remove stale label or comment to keep the issue open.

@github-actions github-actions bot added the stale label Apr 7, 2024
@Ed-Bajo Ed-Bajo changed the title SPIKE 🧐 Figure out how env secrets are added to Control Panel via Flux SPIKE 🧐 Figure out how env secrets are added to Control Panel via Flux Apr 10, 2024
@github-actions github-actions bot removed the stale label Apr 11, 2024
Copy link
Contributor

This issue is being marked as stale because it has been open for 60 days with no activity. Remove stale label or comment to keep the issue open.

@github-actions github-actions bot added the stale label Jun 10, 2024
Copy link
Contributor

This issue is being closed because it has been open for a further 7 days with no activity. If this is still a valid issue, please reopen it, Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
@github-project-automation github-project-automation bot moved this from 👀 TODO to 🎉 Done in Analytical Platform Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools enhancement enhancing an existing feature stale
Projects
Archived in project
Development

No branches or pull requests

1 participant