Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase of feature/running-local-guide with verified commits #124

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

jamesstottmoj
Copy link
Contributor

@jamesstottmoj jamesstottmoj commented Apr 9, 2024

📝 Summary

This PR resolves ministryofjustice/analytical-platform#3702

This PR adds instructions to the readme that describe how to run the dashboard locally via a Dev Container

🔍 What should the reviewer concentrate on?

  • Feedback on the guide

🧑‍💻 How should the reviewer test these changes?

  • Run through the guide to see if it's fit for purpose

📚 Documentation status

  • No changes to the documentation are required

@jamesstottmoj jamesstottmoj marked this pull request as ready for review April 9, 2024 14:56
@jamesstottmoj jamesstottmoj requested a review from a team April 9, 2024 14:56
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesstottmoj jamesstottmoj merged commit 1678a10 into main Apr 9, 2024
18 checks passed
@jamesstottmoj jamesstottmoj deleted the feature/running-local-mk2 branch April 9, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📖 Instructions and demo for running AP UI locally to aid development
2 participants