Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cmake #83

Closed
wants to merge 2 commits into from
Closed

feat: add cmake #83

wants to merge 2 commits into from

Conversation

tom-webber
Copy link

cmake is required for installing some python packages

@tom-webber
feat: add cmake
c4461ca 
cmake is required for installing some python packages
@tom-webber tom-webber requested a review from a team as a code owner January 2, 2025 15:05
michaeljcollinsuk
michaeljcollinsuk approved these changes Jan 2, 2025
View reviewed changes
Copy link

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-webber
Copy link
Author

Just found this was previously marked as not planned and users should use conda for their install of cmake.

Our bias is to not install/manage packages were possible

@tom-webber tom-webber closed this Jan 2, 2025
@tom-webber tom-webber deleted the feat/add-cmake branch January 2, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljcollinsuk michaeljcollinsuk michaeljcollinsuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-webber @michaeljcollinsuk