Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Fix bug in Cloud Platform's prompt #17

Merged
merged 3 commits into from
Feb 5, 2024
Merged

🐞 Fix bug in Cloud Platform's prompt #17

merged 3 commits into from
Feb 5, 2024

Conversation

jacobwoffenden
Copy link
Member

@jacobwoffenden jacobwoffenden commented Feb 1, 2024 •
edited
Loading

This pull request:

  • Removes a rouge && from features/src/cloud-platform/src/home/vscode/.devcontainer/promptrc.d/cloud-platform.sh which caused

    zsh: parse error near `&&'                                                                                                                                                                                                                                                                                         
zsh: parse error in command substitution

  • Updates logic in prompt

Signed-off-by: Jacob Woffenden [email protected]

Fix Cloud Platform prompt
82d6da7 
Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden jacobwoffenden added bug Something isn't working code-quality labels Feb 1, 2024
@jacobwoffenden jacobwoffenden self-assigned this Feb 1, 2024
@jacobwoffenden jacobwoffenden requested a review from a team as a code owner February 1, 2024 17:14
@jacobwoffenden jacobwoffenden marked this pull request as draft February 1, 2024 17:39
Jacob Woffenden added 2 commits February 1, 2024 20:21
@jacobwoffenden jacobwoffenden marked this pull request as ready for review February 2, 2024 07:51
Gary-H9
Gary-H9 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@Gary-H9 Gary-H9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jacobwoffenden jacobwoffenden merged commit c7e1aa8 into main Feb 5, 2024
19 checks passed
@jacobwoffenden jacobwoffenden deleted the hotfix/cloud-platform-prompt branch February 5, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gary-H9 Gary-H9 Gary-H9 approved these changes

Assignees

@jacobwoffenden jacobwoffenden

Labels
bug Something isn't working code-quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobwoffenden @Gary-H9