Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xl-meta: update metadata version #15958

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Oct 27, 2022

Description

Motivation and Context

update metadata version since #15956 bumped up the version

How to test this PR?

for newer objects created with master, should be able to decode metadata

 xl-meta /tmp/multisitea/data/disterasure/xl1/olock/bin/aax/xl.meta
2022/10/27 14:18:49 decodeXLHeaders: Unknown xl meta version 2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to support older version as well does it work with this change too? @poornas

@poornas
Copy link
Contributor Author

poornas commented Oct 27, 2022

We need to support older version as well does it work with this change too? @poornas

it does work with older versions

@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana
Copy link
Member

harshavardhana commented Oct 27, 2022

We need an mc PR as well @poornas for this for mc support inspect --export=json

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking we should maybe move the executable into cmd - or go all out and make it a separate package.

Either way this is fine for now.

@harshavardhana harshavardhana merged commit dc92bb4 into minio:master Oct 28, 2022
@harshavardhana harshavardhana deleted the xlmeta branch October 28, 2022 09:48
@harshavardhana
Copy link
Member

I'm thinking we should maybe move the executable into cmd - or go all out and make it a separate package.

A central package such as at minio/pkg is useful for mc

@bh4t bh4t added the bugfix label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants