Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor XML handling of _complete_multipart_upload() API #994

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Refactor XML handling of _complete_multipart_upload() API #994

merged 1 commit into from
Oct 19, 2020

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Oct 5, 2020 •
edited
Loading

No description provided.

@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-_complete_multipart_upload-API branch from 83dfd86 to c999cf5 Compare October 14, 2020 05:26
@vadmeste
Copy link
Member

@balamurugana can you resolve conflicts of this PR ? some testing fails, probably will be resolved after rebasing it.

@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-_complete_multipart_upload-API branch from c999cf5 to 567fe81 Compare October 15, 2020 21:51
@vadmeste
Copy link
Member

@balamurugana something is wrong with this PR. I am not able to upload an object with 10mb, with this weird error:

S3 operation failed; code: AllAccessDisabled, message: All access to this object has been disabled, resource: None, request_id: 9E51F9F4EEB28241, host_id: T3PvcbI1hUehlq6rjchEmiWxL9kOeaEBaO6x+bRWioXO8oDkWNYRQ3NWSaRLCEFo0F79ncdhltI=

Though it works fine with master.

Could you check ?

@balamurugana
Copy link
Member Author

@balamurugana something is wrong with this PR. I am not able to upload an object with 10mb, with this weird error:

S3 operation failed; code: AllAccessDisabled, message: All access to this object has been disabled, resource: None, request_id: 9E51F9F4EEB28241, host_id: T3PvcbI1hUehlq6rjchEmiWxL9kOeaEBaO6x+bRWioXO8oDkWNYRQ3NWSaRLCEFo0F79ncdhltI=

Though it works fine with master.

Could you check ?

This failure happens when no region passed for the endpoint in the master. #1004 fixes the issue.

kannappanr
kannappanr previously approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-_complete_multipart_upload-API branch from 567fe81 to 56a2ca4 Compare October 19, 2020 10:53
vadmeste
vadmeste approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested

kannappanr
kannappanr approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit d4cc440 into minio:master Oct 19, 2020
@balamurugana balamurugana deleted the Refactor-XML-handling-of-_complete_multipart_upload-API branch October 19, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannappanr kannappanr kannappanr approved these changes

@vadmeste vadmeste vadmeste approved these changes

@sinhaashish sinhaashish Awaiting requested review from sinhaashish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @vadmeste @kannappanr