add {enable,disable,is}_object_legal_hold[_enabled] APIs #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
add-enable-disable-is-object_legal_hold-enabled-apis
branch
2 times, most recently
from
2e749ac to
b640e2d
Compare
balamurugana
force-pushed
the
add-enable-disable-is-object_legal_hold-enabled-apis
branch
from
b640e2d to
4cf7f39
Compare
poornas
requested changes
Oct 16, 2020
| LegalHold, | ||
| """<LegalHold xmlns="http://s3.amazonaws.com/doc/2006-03-01/"> | ||
| <Status>OFF</Status> | ||
| </LegalHold>""", |
There was a problem hiding this comment.
xml indentation is off. Other than that LGTM
There was a problem hiding this comment.
@poornas What do you mean by xml indentation is off? why is it necessary for XML?
balamurugana
force-pushed
the
add-enable-disable-is-object_legal_hold-enabled-apis
branch
from
4cf7f39 to
71fe622
Compare
balamurugana
force-pushed
the
add-enable-disable-is-object_legal_hold-enabled-apis
branch
from
71fe622 to
444ff16
Compare
poornas
approved these changes
Oct 19, 2020
kannappanr
approved these changes
Oct 19, 2020
balamurugana
deleted the
add-enable-disable-is-object_legal_hold-enabled-apis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.