add {set,get}_object_retention() APIs #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
add-set-get_object_retention-apis
branch
from
510835e to
c35407f
Compare
balamurugana
force-pushed
the
add-set-get_object_retention-apis
branch
3 times, most recently
from
58e96d0 to
b30c28f
Compare
|
@balamurugana can this be reviewed? |
Depends on #985 |
balamurugana
force-pushed
the
add-set-get_object_retention-apis
branch
5 times, most recently
from
f16466a to
d6d7bfd
Compare
poornas
requested changes
Oct 22, 2020
minio/api.py
Outdated
| self, bucket_name, object_name, config, version_id=None, | ||
| ): | ||
| """ | ||
| Set retention configuration to an object. |
There was a problem hiding this comment.
Suggested change
| Set retention configuration to an object. | |
| Set retention configuration on an object. |
minio/retention.py
Outdated
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Request/response of PutBucketReplication and GetBucketReplication APIs.""" |
There was a problem hiding this comment.
Suggested change
| """Request/response of PutBucketReplication and GetBucketReplication APIs.""" | |
| """Request/response of PutObjectRetention and GetObjectRetention APIs.""" |
balamurugana
force-pushed
the
add-set-get_object_retention-apis
branch
from
d6d7bfd to
9a3f9ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.