Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty prefix in Filter #1053

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Allow empty prefix in Filter #1053

merged 1 commit into from
Jan 5, 2021

Conversation

balamurugana
Copy link
Member

No description provided.

@balamurugana balamurugana force-pushed the allow-empty-prefix-in-filter branch from d8db891 to 7213bd1 Compare January 5, 2021 04:44
harshavardhana
harshavardhana requested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change needed is to treat element.text is None as "" empty string.

@balamurugana balamurugana force-pushed the allow-empty-prefix-in-filter branch from 7213bd1 to ef2d393 Compare January 5, 2021 04:54
@balamurugana balamurugana merged commit b51c0a7 into minio:master Jan 5, 2021
@balamurugana balamurugana deleted the allow-empty-prefix-in-filter branch January 5, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praveenrajmani Praveenrajmani Praveenrajmani approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @harshavardhana @Praveenrajmani