Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples and documentations #1038

Merged

Conversation

balamurugana
Copy link
Member

No description provided.

@balamurugana balamurugana marked this pull request as draft December 1, 2020 08:46
@balamurugana balamurugana force-pushed the fix-examples-and-documentations branch 3 times, most recently from 86e5217 to 9163164 Compare December 2, 2020 12:30
@balamurugana balamurugana force-pushed the fix-examples-and-documentations branch from 9163164 to 41eda21 Compare December 3, 2020 01:48
docs/API.md Show resolved Hide resolved
docs/API.md Show resolved Hide resolved
docs/API.md Show resolved Hide resolved
docs/API.md Show resolved Hide resolved
examples/stat_object.py Show resolved Hide resolved
@balamurugana balamurugana force-pushed the fix-examples-and-documentations branch 4 times, most recently from f1411e1 to 53a2a87 Compare December 3, 2020 17:13
ebozduman
ebozduman previously approved these changes Dec 4, 2020
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the fix-examples-and-documentations branch from 86e9094 to a4c2dbd Compare December 5, 2020 01:20
@balamurugana balamurugana marked this pull request as ready for review December 5, 2020 01:21
@balamurugana balamurugana force-pushed the fix-examples-and-documentations branch from a4c2dbd to 3137e36 Compare December 5, 2020 04:59
@kannappanr kannappanr requested a review from ravindk89 December 5, 2020 05:59
@balamurugana balamurugana force-pushed the fix-examples-and-documentations branch from 3137e36 to ea3578d Compare December 5, 2020 10:23
ebozduman
ebozduman previously approved these changes Dec 6, 2020
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, most of my feedback are nits and are closer to being "polish" than something that is absolutely necessary. If the priority is to get this out, I don't think anything here would be a hard block to user success.

CONTRIBUTING.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
This example program connects to a MinIO object storage server, makes a bucket on the server and then uploads a file to the bucket.
This example program connects to an object storage server, makes a bucket on the server and then uploads a file to the bucket.

You need three items in order to connect to an object storage server.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You need three items in order to connect to an object storage server.
You need the following items to connect to an S3-compatible object storage server:

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/API.md Show resolved Hide resolved
docs/API.md Show resolved Hide resolved
docs/API.md Show resolved Hide resolved
minio/api.py Show resolved Hide resolved
@ebozduman ebozduman self-requested a review December 7, 2020 20:37
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit f251575 into minio:master Dec 7, 2020
@balamurugana balamurugana deleted the fix-examples-and-documentations branch December 8, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants