Fix issues with browser environment #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakashsvmx
force-pushed
the
fix-for-web-browser
branch
from
dcdce5c to
562cf8f
Compare
kanagarajkm
reviewed
Aug 13, 2021
| @@ -16,6 +16,7 @@ | |||
|
|
|||
| import stream from 'stream' | |||
| import mime from 'mime-types' | |||
| var Crypto = require('crypto') | |||
There was a problem hiding this comment.
can we do import Crypto from 'crypto'?
There was a problem hiding this comment.
This imports based on browserify environment. So this is needed. For md5 to to be browserified and work in browser environment.
kanagarajkm
approved these changes
Aug 13, 2021
harshavardhana
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues with browser environment
Fixes #954
How to test:
Replicating the issue:
Clone and run : https://github.com/prakashsvmx/minio-js-web-browser-example
npm installnpm startCreate bucket, upload objects and remove All
Note the error
Testing the fix:
Checkout this branch and run the below commands
npm installnpm run lintnpm run browserifynpm run test- Optional since it runs unit test and functional testsrun
npm linkon the root folder this is importantClone : https://github.com/prakashsvmx/minio-js-web-browser-example
npm installnpm link minio- this is important to get this fix into this repo for local testingnpm start