Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versionId support in presigned url #913

Merged
merged 3 commits into from
May 27, 2021

Conversation

prakashsvmx
Copy link
Member

VersionId support in pre signed url ( get)

kannappanr
kannappanr previously approved these changes Mar 13, 2021
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/presigned-getobject-request-date.js Outdated Show resolved Hide resolved
examples/presigned-getobject-request-date.js Outdated Show resolved Hide resolved
@prakashsvmx
Copy link
Member Author

@ebozduman Thank you for the review. I have addressed the comments. PTAL

ebozduman
ebozduman previously approved these changes Mar 17, 2021
Copy link
Contributor

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebozduman
Copy link
Contributor

Oops!
@prakashsvmx
Please take a look into the build failures

@kannappanr
Copy link
Contributor

@prakashsvmx Please resolve the conflicts

ebozduman
ebozduman previously approved these changes Mar 22, 2021
Copy link
Contributor

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit d6b4aea into minio:master May 27, 2021
@prakashsvmx prakashsvmx deleted the versioned-presigned-url branch February 10, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants