-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
versionId support in presigned url #913
Conversation
ecafd37
to
9e72d53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ebozduman Thank you for the review. I have addressed the comments. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oops! |
@prakashsvmx Please resolve the conflicts |
b31daa2
to
3543e18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
264510a
to
8df4196
Compare
Signed-off-by: prakashsvmx <[email protected]>
Signed-off-by: prakashsvmx <[email protected]>
Signed-off-by: prakashsvmx <[email protected]>
8df4196
to
3acd872
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
VersionId support in pre signed url ( get)