VersionId Support in removeObjects api

[prakashsvmx]

VersionId Support in removeObjects api

[kannappanr]

LGTM

[ebozduman]

Non-versioned listObjects output is accepted by removeObjects api as is, but when it comes to versioned objects, user is supposed to manipulate the output and set the objects list with specific key names:

 {
    Key: <object-name>
    VersionId:  <version-id>
  },
  {
    Key: <object-name>
    VersionId:  <version-id>
  },
  :
  : 

IMHO, the deleteList should stick with the same nomenclature listObjects api returns.
Here is what listObjects api output looks like for versioned objects:

  {
    name: <object-name>
    versionId:  <version-id>
  },
  {
    name: <object-name>
    versionId:  <version-id>
  },
  :
  : 

This is confusing for the end user, that is, sometimes it is ok to feed the output of listObjects api to removeObjects api without any manipulation, and sometimes it should be manipulated before feeding it to removeObjects api.

I think, removeObjects api should always take the listObjects output as is regardless of the type of listing, and we need to take care of required structural key name changes internally.

[ebozduman]

To achieve the suggested change in the above comment, we need a one line change here:

Suggested change

	entry={"Object": [{"Key": value.Key, "VersionId":value.VersionId}]}
	entry={"Object": [{"Key": value.name, "VersionId":value.versionId}]}

[ebozduman]

Assuming the other 2 suggested changes/comments are accepted, this example script can be simplified to work for both versioned and non-versioned scenarios:

var objectsList = []
var bucket = '<bucket-name>'
var prefix = '<prefix-name>'
var recursive = <true | false>
var includeVersion = <true | false>

// List all object paths in bucket
var objectsStream = s3Client.listObjects(bucket, prefix, recursive, {IncludeVersion: includeVersion})

objectsStream.on('data', function(obj) {
  if (includeVersion) {
    objectsList.push(obj)
  } else {
    objectsList.push(obj.name)
  }
})

objectsStream.on('error', function(e) {
  return console.log(e)
})

objectsStream.on('end', function() {
  s3Client.removeObjects(bucket, objectsList, function(e) {
    if (e) {
      return console.log(e)
    }
    console.log("Success")
  })
})

[prakashsvmx]

Thank you for the suggestion. I will refactor.

[ebozduman]

Couple of minor changes...

[ebozduman]

LGTM