Change linebreak-style rule to support both Windows and Unix #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'linebreak-style' rule was enforcing the usage of Unix linebreaks causing the CI runs on Windows setups to return errors. This is based on the fact that linebreaks in Windows are CRLF (carriage return + line feed) as opposed to LF (line feed) in Unix. The format of the .eslintrc file has been switched from .yaml to .js to support the usage of the required conditional statement to detect the operating system.
kaankabalak
force-pushed
the
eslint-detect-os
branch
from
61b5d63
to
55c48f9
Compare
kanagarajkm
approved these changes
Dec 18, 2019
Praveenrajmani
approved these changes
Dec 18, 2019
|
@kaankabalak could you check the travis failure pls |
I see CONN_RESET errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'linebreak-style' rule was enforcing the usage of Unix linebreaks
causing the CI runs on Windows setups to return errors. This is based on
the fact that linebreaks in Windows are CRLF (carriage return + line
feed) as opposed to LF (line feed) in Unix.
The format of the .eslintrc file has been switched from .yaml to .js to
support the usage of the required conditional statement to detect the
operating system.