Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces Minio refs with MinIO and minio.io links with min.io #762

Merged
merged 2 commits into from
Apr 5, 2019

Conversation

ebozduman
Copy link
Contributor

@ebozduman ebozduman commented Apr 5, 2019

Official company name Minio became MinIO.
This change requires all references in the code and documentation to be modified as MinIO and the links, ....://xxx.minio.io, to be ....://xxx.min.io.

Description of the change

Here are the changes done .

Used Visual Studio Code Editor regular expressions to find and replace those patterns that match the desired text in all minio-js repo files. Here are the two regular expressions used to complete the job in 2 steps:

  1. Set files to include to *.md, choose Match Case and Use Regular Expression and replace the links using the following regular expressions:
Find Replace
(//(slack|docs|play|dl|blog).|//)minio.io $1min.io

The above regular expression, as can be seen, replaces the links that start with either slack or docs or ``playordl` or `blog` or nothing before `minio.io`.

Find Replace
\bMinio\b(?!( *=|.| *from)) MinIO

The above regular expression replaces the string "Minio" with "MinIO" except the following forms:

  • Minio =, as in a variable setting like var Minio = .... in the code
  • Minio. as in Minio.Client in the code
  • Minio from as in import * as Minio from ... in the code

Please pay specific attention to the following changes:
gulpfile.js
line# 29

package.json
line#s 19, 21

src/main/minio.js
line#s 108, 111, 226

src/main/test/unit/test.js
line#s 280, 290, 300

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit f2c3731 into minio:master Apr 5, 2019
@ebozduman ebozduman requested review from donatello and removed request for donatello April 5, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants