Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase default part-size to 64MB and provide a way to over-ride the default part size #759

Merged
merged 1 commit into from
Jun 8, 2019
Merged

Increase default part-size to 64MB and provide a way to over-ride the default part size #759

merged 1 commit into from
Jun 8, 2019

Conversation

krishnasrinivas
Copy link
Contributor

No description provided.

@ebozduman
Copy link
Contributor

@krishnasrinivas ,
Could you look into the travis failure?

@kannappanr kannappanr mentioned this pull request Mar 26, 2019
Closed
@ebozduman
Copy link
Contributor

Adding a functional test could be a good idea.

@ebozduman
Copy link
Contributor

README.md and README_zh_CN.md files need to be updated and missing parameters need to be added into them.

ebozduman
ebozduman requested changes Mar 26, 2019
View reviewed changes
src/main/minio.js Outdated Show resolved Hide resolved
docs/API.md Show resolved Hide resolved
@krishnasrinivas
Copy link
Contributor Author

@ebozduman @kannappanr can you check now

kannappanr
kannappanr reviewed Mar 28, 2019
View reviewed changes
src/main/minio.js Outdated Show resolved Hide resolved
@ebozduman
Copy link
Contributor

@krishnasrinivas,
How about the missing changes in documentation files, docs/zh_CN/API.md, README.md and README_zh_CN.md?

@harshavardhana
Copy link
Member

ping @krishnasrinivas can you make the changes requested by @ebozduman ?

@krishnasrinivas
Copy link
Contributor Author

@kannappanr @ebozduman can you review the PR again? your comments have been addressed.

@krishnasrinivas krishnasrinivas force-pushed the partsize-64mb branch 2 times, most recently from de899f1 to 4871e6c Compare May 28, 2019 23:51
kannappanr
kannappanr approved these changes Jun 8, 2019
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 3e5fe33 into minio:master Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebozduman ebozduman ebozduman requested changes

@kannappanr kannappanr kannappanr approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krishnasrinivas @ebozduman @harshavardhana @kannappanr