Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing metadata length check #739

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Removing metadata length check #739

merged 1 commit into from
Jan 2, 2019

Conversation

kannappanr
Copy link
Contributor

Metadata length check will fail if auto encryption is turned on,
as auto encryption adds extra metadata.

@kannappanr
Removing metadata length check
9fb253a 
Metadata length check will fail if auto encryption is turned on,
as auto encryption adds extra metadata.
harshavardhana
harshavardhana approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we should avoid making these assumptions in future tests. There is no set standard on how many headers might be there etc.

ebozduman
ebozduman approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit faa7be3 into minio:master Jan 2, 2019
@jefvel jefvel mentioned this pull request Jan 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebozduman ebozduman ebozduman approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kannappanr @harshavardhana @ebozduman