Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter start-after to ListObjectsV2 #734

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Add parameter start-after to ListObjectsV2 #734

merged 1 commit into from
Dec 3, 2018

Conversation

sinhaashish
Copy link
Contributor

Add parameter start-after to ListObjectsV2 to make the iteration uninterruptible.

Resolves the issue

Praveenrajmani
Praveenrajmani previously approved these changes Nov 29, 2018
View reviewed changes
Copy link
Collaborator

@Praveenrajmani Praveenrajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & LGTM

ebozduman
ebozduman reviewed Nov 30, 2018
View reviewed changes
src/main/minio.js Outdated Show resolved Hide resolved
src/main/minio.js Outdated Show resolved Hide resolved
src/main/minio.js Outdated Show resolved Hide resolved
docs/API.md Outdated Show resolved Hide resolved
@ebozduman
Copy link
Contributor

It'd be a good idea to visit and modify the functional-tests.js file to add the new argument, startAfter, although existing listObjectsV2 test still runs fine, since startAfter is optional.
However, it is preferably better to add a new test to check the new functionality.

@sinhaashish
Copy link
Contributor Author

sinhaashish commented Nov 30, 2018 •
edited
Loading

It'd be a good idea to visit and modify the functional-tests.js file to add the new argument, startAfter, although existing listObjectsV2 test still runs fine, since startAfter is optional.
However, it is preferably better to add a new test to check the new functionality.

Added the field with blank value for start-After.

@sinhaashish
Copy link
Contributor Author

@ebozduman PTAL

ebozduman
ebozduman requested changes Dec 1, 2018
View reviewed changes
src/main/minio.js Outdated Show resolved Hide resolved
@sinhaashish
Add parameter start-after to ListObjectsV2
27f7c05 
Add parameter start-after to ListObjectsV2 to make the iteration interruptible
ebozduman
ebozduman approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr removed the blocked label Dec 3, 2018
@kannappanr kannappanr merged commit 6489ee2 into minio:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebozduman ebozduman ebozduman approved these changes

@Praveenrajmani Praveenrajmani Praveenrajmani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sinhaashish @ebozduman @Praveenrajmani @deekoder @kannappanr