Add requestDate parameter to presignedUrl() and presignedGetObject()

[dustin-H]

Hi there,

I just added a parameter requestDate to the methods presignedUrl() and presignedGetObject().

Please have a look at #724 for more details.

My todo checklist:

• Adjust the code
• Add js-doc parameter description
• Create new tests for the functionality
• All (old and new) tests should pass
• Update docs
• Create example

[ebozduman]

Title above also needs to be modified accordingly, line# 751:

### presignedGetObject(bucketName, objectName, expiry[, cb])
=>
### presignedGetObject(bucketName, objectName[, expiry, respHeaders, requestDate, cb])

(optinal) information should be added to the above expiry and requestDate descriptions.

[dustin-H]

Fixed in 29b457a

[ebozduman]

LGTM

[ebozduman]

@dustin-H,
There is also a travis failure you need to address:

  let code = codeRegex();
  ^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
    at NativeCompileCache._moduleCompile (/home/travis/.nvm/versions/node/v5.12.0/lib/node_modules/yarn/lib/v8-compile-cache.js:226:18)
    at Module._compile (/home/travis/.nvm/versions/node/v5.12.0/lib/node_modules/yarn/lib/v8-compile-cache.js:172:36)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/travis/.nvm/versions/node/v5.12.0/lib/node_modules/yarn/bin/yarn.js:24:13)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)

[dustin-H]

@ebozduman
Yes, I've seen this.

However, I think this is a yarn issue yarnpkg/yarn#6619.

I haven't changed anything regarding this.

[dustin-H]

@ebozduman
I fixed it by setting the yarn version in .travis.yml to [email protected].

This is the latest version, which has successfully passed the last travis build.

[ebozduman]

@dustin-H,
Perfect. Great job!

[ebozduman]

LGTM

[dustin-H]

The build is currently failing, because a package down the dependency tree has published a major release (node-version changed) as patch.

I'm talking about graceful-fs

They changed from 0.4.11 to 0.4.12 the node min version: (Now the latest is 0.4.13)

https://cdn.jsdelivr.net/npm/[email protected]/package.json
https://cdn.jsdelivr.net/npm/[email protected]/package.json

I already created an issue: isaacs/node-graceful-fs#146

However, we may could prevent errors like this by creating a lockfile.

[dustin-H]

@ebozduman Now, everything is ready thanks to isaacs/node-graceful-fs#141 (comment).

[ebozduman]

LGTM

[dustin-H]

@ebozduman @krishnasrinivas

Do you know, when this will be merged. I really need this.

[kannappanr]

@dustin-H Thanks for the PR. This has been merged. We will make a release in the next few days.

[dustin-H]

Thanks you!