-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Type annotation work #655
Conversation
This PR is not needed anymore since we have https://github.com/minio/minio-js#using-with-typescript ?? @krishnasrinivas @kaankabalak |
@harshavardhana I think they are separate, as the link you have provided adds the TypeScript declaration file that describes the type information of our JavaScript library for third party developers who would like to use it in their TypeScript projects; while this PR aims to do so by migrating the existing codebase of minio-js from JavaScript to TypeScript (which would also help us to easily catch type errors/inconsistencies on code compilation and make the code more understandable). However, it might be a good idea to change the header for that link to prevent any confusion. |
Then are we interested in continuing this work, since we haven't had any movement in this PR for past 3 months?? |
@harshavardhana As the end goal was to produce the type annotations, and the link you gave accomplishes it, I think this issue can be closed given that we don't want to migrate to TypeScript. If we want to convert the project to TypeScript in the future for any reason, we can continue from this PR. |
I'm not using the project anymore, so I'm not likely to be finishing these. Anyone else who wants to use this stuff is free to pick up where I left off. |
As requested in #611 (comment), here's my (incomplete) work on converting the project to TypeScript with the goal of being able to produce accurate type annotations.
WIP for #611.