Update buffer-crc32 to 1.0.0 #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
commented
Feb 10, 2024
| @@ -106,7 +106,6 @@ | |||
| "@nodelib/fs.walk": "^1.2.8", | |||
| "@types/async": "^3.2.20", | |||
| "@types/block-stream2": "^2.1.2", | |||
| "@types/buffer-crc32": "^0.2.4", | |||
There was a problem hiding this comment.
TS types are bundled now
|
👍 Thank you for the contribution and we will test/review. @kibertoad |
prakashsvmx
approved these changes
Feb 13, 2024
kaankabalak
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! We've spent some effort lately to clean up the buffer-crc32 library and push the 1.0.0 release forward. Thought you may want to upgrade! Should be a drop-in replacement, as you don't support very old Node.js versions already.