Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update examples #1235

Merged
merged 11 commits into from
Nov 21, 2023
Merged

update examples #1235

merged 11 commits into from
Nov 21, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Nov 9, 2023

use new esm import syntax and const/let instead var

@trim21 trim21 marked this pull request as ready for review November 9, 2023 14:30
@trim21 trim21 changed the title upgrade examples update examples Nov 10, 2023
@trim21
Copy link
Contributor Author

trim21 commented Nov 21, 2023

@prakashsvmx doesn't this pr need more reviewers?

@prakashsvmx prakashsvmx merged commit 2f98eec into minio:master Nov 21, 2023
14 checks passed
@trim21 trim21 deleted the update-examples branch November 21, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakashsvmx prakashsvmx prakashsvmx approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trim21 @harshavardhana @prakashsvmx