Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor listIncompleteUploads to TypeScript #1228

Merged
merged 13 commits into from
Nov 18, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Nov 3, 2023

function signature didn't change, no need to update documents and examples

@trim21 trim21 marked this pull request as ready for review November 3, 2023 19:12
@trim21 trim21 marked this pull request as draft November 5, 2023 10:01
@trim21 trim21 changed the title refactor listIncompleteUploads to TypeScript [WIP] refactor listIncompleteUploads to TypeScript Nov 8, 2023
@trim21 trim21 marked this pull request as ready for review November 14, 2023 03:48
@trim21 trim21 changed the title [WIP] refactor listIncompleteUploads to TypeScript refactor listIncompleteUploads to TypeScript Nov 14, 2023
@trim21
Copy link
Contributor Author

trim21 commented Nov 14, 2023

@prakashsvmx

src/internal/xml-parser.ts Outdated Show resolved Hide resolved
prakashsvmx
prakashsvmx previously approved these changes Nov 15, 2023
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. LGTM 👍

@trim21
Copy link
Contributor Author

trim21 commented Nov 15, 2023

@kaankabalak

@prakashsvmx prakashsvmx merged commit 796d0d6 into minio:master Nov 18, 2023
14 checks passed
@trim21 trim21 deleted the listIncompleteUploads branch November 18, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants