Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor getBucketTagging, getObjectTagging to TypeScript #1211

Merged
merged 16 commits into from
Oct 23, 2023
Merged

refactor getBucketTagging, getObjectTagging to TypeScript #1211

merged 16 commits into from
Oct 23, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Sep 25, 2023

No description provided.

@trim21 trim21 marked this pull request as draft September 25, 2023 05:16
@trim21 trim21 changed the title refactor getBucketTagging to TypeScript refactor getBucketTagging, getObjectTagging to TypeScript Sep 25, 2023
@trim21 trim21 marked this pull request as ready for review September 25, 2023 06:03
prakashsvmx
prakashsvmx approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@trim21
Copy link
Contributor Author

trim21 commented Oct 17, 2023

@kaankabalak

kaankabalak
kaankabalak approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@kaankabalak kaankabalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prakashsvmx prakashsvmx merged commit a572dca into minio:master Oct 23, 2023
14 checks passed
@trim21 trim21 deleted the get-bucket-tagging branch October 23, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaankabalak kaankabalak kaankabalak approved these changes

@prakashsvmx prakashsvmx prakashsvmx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trim21 @prakashsvmx @kaankabalak