Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor listBuckets #1179

Merged
merged 8 commits into from
Jul 6, 2023
Merged

refactor listBuckets #1179

merged 8 commits into from
Jul 6, 2023

Conversation

prakashsvmx
Copy link
Member

refactor listBuckets to typescript

@prakashsvmx prakashsvmx self-assigned this Jun 28, 2023
src/internal/client.ts Outdated Show resolved Hide resolved
examples/list-buckets.js Outdated Show resolved Hide resolved
src/internal/xml-parser.ts Outdated Show resolved Hide resolved
src/internal/xml-parser.ts Outdated Show resolved Hide resolved
@trim21
Copy link
Contributor

trim21 commented Jul 3, 2023

Import type from minio.d.ts will cause resolution problem in dist files

docs/API.md Outdated Show resolved Hide resolved
@prakashsvmx prakashsvmx requested a review from trim21 July 4, 2023 05:23
@trim21
Copy link
Contributor

trim21 commented Jul 4, 2023

lgtm

docs/API.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kaankabalak kaankabalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prakashsvmx prakashsvmx requested a review from trim21 July 6, 2023 03:51
Copy link
Contributor

@trim21 trim21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants