-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rewrite Extension in TypeScript #1164
Conversation
@trim21 I have tested and verified ( for the following important cases)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. LGTM 👍
@kaankabalak please? |
Hi @trim21, would it be possible to address the conflicts? |
@kaankabalak done |
API result of
ListObjectsV2WithMetadata
doesn't match go sdk,CommonPrefixes
result are stored asobjects
, is this expected? or it's a bug?https://github.com/minio/minio-go/blob/68418bf9a5bb03337c8349523a5b188feb5ff2be/api-s3-datatypes.go#L201-L203