Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: start minio as first step #1149

Merged
merged 1 commit into from
May 12, 2023
Merged

ci: start minio as first step #1149

merged 1 commit into from
May 12, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented May 12, 2023

avoid flaky test


  1) functional tests
       "before all" hook in "functional tests":
     S3Error: Server not initialized, please try again.
      at Object.parseError (src\/xml-parsers.js:37:11)
      at parser (src\/transformers.js:121:22)
      at Transform._flush (src\/transformers.js:51:12)
      at Transform.prefinish (node_modules\readable-stream\lib\_stream_transform.js:123:10)
      at Transform.emit (node:events:511:28)
      at prefinish (node_modules\readable-stream\lib\_stream_writable.js:569:14)
      at finishMaybe (node_modules\readable-stream\lib\_stream_writable.js:576:5)
      at endWritable (node_modules\readable-stream\lib\_stream_writable.js:594:3)
      at Transform.Writable.end (node_modules\readable-stream\lib\_stream_writable.js:535:22)
      at IncomingMessage.onend (node:internal/streams/readable:713:10)
      at Object.onceWrapper (node:events:625:28)
      at IncomingMessage.emit (node:events:523:35)
      at endReadableNT (node:internal/streams/readable:1367:12)
      at processTicksAndRejections (node:internal/process/task_queues:82:21)

@trim21 trim21 marked this pull request as draft May 12, 2023 01:41
@trim21 trim21 marked this pull request as ready for review May 12, 2023 02:03
@trim21
Copy link
Contributor Author

trim21 commented May 12, 2023

@aldy505 minio:edge-cicd is too old and minio doesn't have a windows native docker image. Using docker image is not possible on windows, even latest or edge tag.

Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@prakashsvmx prakashsvmx merged commit 766eb40 into minio:master May 12, 2023
@aldy505
Copy link
Contributor

aldy505 commented May 12, 2023

@aldy505 minio:edge-cicd is too old and minio doesn't have a windows native docker image. Using docker image is not possible on windows, even latest or edge tag.

@trim21 regarding that, I'd actually wanted to suggest the minio team to create that image on each release (or on the main branch). Personally, I have an image to do that: https://github.com/aldy505/continuous-integration-images/blob/master/minio/Dockerfile But I don't think it's something that's good to use here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants