fix STS token support for presign

PR #830 was incomplete, this PR completes sessionToken support Fixes #829
minio · Feb 22, 2020 · 127425b · 127425b
1 parent cf1b28f
commit 127425b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/main/minio.js b/src/main/minio.js
@@ -1617,7 +1617,7 @@ export class Client {
                                                query})
       try {
         url = presignSignatureV4(reqOptions, this.accessKey, this.secretKey,
-                                 region, requestDate, expires)
+                                 this.sessionToken, region, requestDate, expires)
       } catch (pe) {
         return cb(pe)
       }

diff --git a/src/main/signing.js b/src/main/signing.js
@@ -220,7 +220,7 @@ export function signV4(request, accessKey, secretKey, region, requestDate) {
 }
 
 // returns a presigned URL string
-export function presignSignatureV4(request, accessKey, secretKey, region, requestDate, expires) {
+export function presignSignatureV4(request, accessKey, secretKey, sessionToken, region, requestDate, expires) {
   if (!isObject(request)) {
     throw new TypeError('request should be of type "object"')
   }
@@ -262,8 +262,6 @@ export function presignSignatureV4(request, accessKey, secretKey, region, reques
   requestQuery.push(`X-Amz-Date=${iso8601Date}`)
   requestQuery.push(`X-Amz-Expires=${expires}`)
   requestQuery.push(`X-Amz-SignedHeaders=${uriEscape(signedHeaders.join(';').toLowerCase())}`)
-
-  var sessionToken = request.headers['x-amz-security-token']
   if (sessionToken) {
     requestQuery.push(`X-Amz-Security-Token=${sessionToken}`)
   }