Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix license register error in airgap mode #4653

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

anjalshireesh
Copy link
Contributor

Description

A network lookup was happening even in airgap mode, resulting in failure of the command.

Motivation and Context

Bugfix

How to test this PR?

  • Ensure that your client machine doesn't have internet connectivity
  • Run mc license register <alias> --airgap
  • Verify that the command doesn't error out and prints the subnet url to be visited for registration

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

@harshavardhana harshavardhana merged commit e112429 into minio:master Aug 10, 2023
5 checks passed
harshavardhana pushed a commit to miniohq/mc-legacy that referenced this pull request Aug 10, 2023
@anjalshireesh anjalshireesh deleted the bugfix branch August 11, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants