Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to get prometheus configs for node and bucket endpoints #4652

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Option to get prometheus configs for node and bucket endpoints #4652

merged 2 commits into from
Aug 8, 2023

Conversation

shtripat
Copy link
Contributor

@shtripat shtripat commented Aug 8, 2023

Earlier the command mc admin prometheus generate ALIAS used to display only the scrape configuration for cluster metrics endpoint. This change enables optionally to display scrape configuration for node / bucket metrics endpoints.

Description

Motivation and Context

How to test this PR?

mc admin prometheus generate ALIAS bucket
mc admin prometheus generate ALIAS node

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@shtripat
Option to get prometheus configs for node and bucket endpoints
c8b722b 
Earlier the command `mc admin prometheus generate ALIAS` used to
display only the scrape configuration for cluster metrics endpoint.
This change enables optionally to display scrape configuration for
node / bucket metrics endpoints.

Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
vadmeste
vadmeste approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 01fb7c5 into minio:master Aug 8, 2023
5 checks passed
@djwfyi djwfyi mentioned this pull request Aug 10, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@vadmeste vadmeste vadmeste approved these changes

@kannappanr kannappanr Awaiting requested review from kannappanr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shtripat @vadmeste @harshavardhana