Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support perf client to show TX from client to server #4645

Merged
merged 12 commits into from
Aug 10, 2023
Merged

feat: support perf client to show TX from client to server #4645

merged 12 commits into from
Aug 10, 2023

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Jul 25, 2023 •
edited
Loading

Description

Motivation and Context

show TX from client to server

How to test this PR?

#> .\mc support perf client minio

Client: ✔

ENDPOINT                TX
http://127.0.0.1:9000   269 MiB/s

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@jiuker jiuker mentioned this pull request Jul 25, 2023
Merged
8 tasks
guozhi.li added 2 commits July 27, 2023 19:43
@jiuker jiuker marked this pull request as draft July 27, 2023 12:40
@jiuker jiuker marked this pull request as ready for review July 28, 2023 02:02
harshavardhana
harshavardhana requested changes Aug 9, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
shtripat
shtripat reviewed Aug 10, 2023
View reviewed changes
cmd/support-perf.go Outdated Show resolved Hide resolved
@jiuker jiuker requested a review from shtripat August 10, 2023 12:23
shtripat
shtripat approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit 44ca181 into minio:master Aug 10, 2023
@djwfyi djwfyi mentioned this pull request Aug 17, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@shtripat shtripat shtripat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiuker @harshavardhana @shtripat