Skip to content

Commit

Permalink
disable arm64 assembler and update CI to Go 1.16 (#18)
Browse files Browse the repository at this point in the history
This commit disables the arm64 asm implementation since
it is broken and produces incorrect results on Go 1.16.

Further, this commit updates CI to the Go 1.16 and 1.15.
Once, CI tests for arm64 pass again we can enable it.
  • Loading branch information
Andreas Auernhammer authored Mar 25, 2021
1 parent 86a2a96 commit 5311fe9
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go-version: [1.14.x, 1.15.x]
go-version: [1.15.x, 1.16.x]
steps:
- name: Set up Go ${{ matrix.go-version }}
uses: actions/setup-go@v1
Expand All @@ -29,15 +29,15 @@ jobs:
env:
GO111MODULE: on
run: |
curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.20.0
curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.33.0
$(go env GOPATH)/bin/golangci-lint run --config ./.golangci.yml
go vet ./...
test:
name: Testing Go ${{ matrix.go-version }} on ${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
go-version: [1.15.x]
go-version: [1.16.x]
os: [ubuntu-latest, windows-latest, macos-latest]
steps:
- name: Set up Go ${{ matrix.go-version }} on ${{ matrix.os }}
Expand Down
2 changes: 2 additions & 0 deletions highwayhash_arm64.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// Use of this source code is governed by a license that can be
// found in the LICENSE file.

//+build ignore

//+build !noasm,!appengine

package highwayhash
Expand Down
2 changes: 2 additions & 0 deletions highwayhash_arm64.s
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
// limitations under the License.
//

//+build ignore

//+build !noasm,!appengine

// Use github.com/minio/asm2plan9s on this file to assemble ARM instructions to
Expand Down
2 changes: 1 addition & 1 deletion highwayhash_ref.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a license that can be
// found in the LICENSE file.

// +build noasm !amd64,!arm64,!ppc64le
// +build noasm !amd64,!ppc64le

package highwayhash

Expand Down

0 comments on commit 5311fe9

Please sign in to comment.